From 4a95e5fe8f394ae379f6e40cda856271ae2b981f Mon Sep 17 00:00:00 2001
From: Derek Brans <dbrans@gmail.com>
Date: Thu, 30 May 2024 15:42:11 -0400
Subject: [PATCH] fix: TransactionController afterSign hook should be allowed
 to modify the transaction

---
 .../transaction-controller/src/TransactionController.ts    | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/packages/transaction-controller/src/TransactionController.ts b/packages/transaction-controller/src/TransactionController.ts
index 76a8158ddf..06010fc314 100644
--- a/packages/transaction-controller/src/TransactionController.ts
+++ b/packages/transaction-controller/src/TransactionController.ts
@@ -3289,9 +3289,10 @@ export class TransactionController extends BaseController<
       return undefined;
     }
 
-    if (!this.afterSign(transactionMeta, signedTx)) {
+    const transactionMetaFromHook = cloneDeep(transactionMeta);
+    if (!this.afterSign(transactionMetaFromHook, signedTx)) {
       this.updateTransaction(
-        transactionMeta,
+        transactionMetaFromHook,
         'TransactionController#signTransaction - Update after sign',
       );
 
@@ -3301,7 +3302,7 @@ export class TransactionController extends BaseController<
     }
 
     const transactionMetaWithRsv = {
-      ...this.updateTransactionMetaRSV(transactionMeta, signedTx),
+      ...this.updateTransactionMetaRSV(transactionMetaFromHook, signedTx),
       status: TransactionStatus.signed as const,
     };