From b7c3e84fd88167194e43274d3974dc1d206d0db3 Mon Sep 17 00:00:00 2001
From: Elliot Winkler <elliot.winkler@gmail.com>
Date: Mon, 13 Jul 2026 11:21:09 -0600
Subject: [PATCH] [snap-account-service] Remove extra account-tree-controller
 dep

In a future commit, we want to automatically synchronize the
`references` field in each package's tsconfig files with that package
dependencies. Currently, we would have to make an exception for
`snap-account-service`, as it lists `account-tree-controller` as a
dependency but purposefully excludes it from its tsconfig files to avoid
a circular reference. However, this manual bookkeeping is unnecessary,
as `snap-account-service` already works around the circular
dependency by copying types from `account-tree-controller` instead of
importing them. So the dependency is unnecessary and we can drop it from
`package.json`, thereby unlocking `package.json`<->tsconfig syncing.
---
 README.md                                         | 1 -
 packages/snap-account-service/package.json        | 1 -
 packages/snap-account-service/tsconfig.build.json | 9 ---------
 packages/snap-account-service/tsconfig.json       | 9 ---------
 yarn.lock                                         | 1 -
 5 files changed, 21 deletions(-)

diff --git a/README.md b/README.md
index 91a8cc10478..6e0cbc95cb7 100644
--- a/README.md
+++ b/README.md
@@ -583,7 +583,6 @@ linkStyle default opacity:0.5
   smart_transactions_controller --> remote_feature_flag_controller;
   smart_transactions_controller --> transaction_controller;
   smart_transactions_controller --> json_rpc_engine;
-  snap_account_service --> account_tree_controller;
   snap_account_service --> keyring_controller;
   snap_account_service --> messenger;
   social_controllers --> base_controller;
diff --git a/packages/snap-account-service/package.json b/packages/snap-account-service/package.json
index aaa22e3d664..47f3bf17e27 100644
--- a/packages/snap-account-service/package.json
+++ b/packages/snap-account-service/package.json
@@ -54,7 +54,6 @@
   },
   "dependencies": {
     "@metamask/account-api": "^1.0.4",
-    "@metamask/account-tree-controller": "^7.5.5",
     "@metamask/eth-snap-keyring": "^23.0.0",
     "@metamask/keyring-api": "^23.5.0",
     "@metamask/keyring-controller": "^27.1.0",
diff --git a/packages/snap-account-service/tsconfig.build.json b/packages/snap-account-service/tsconfig.build.json
index f5d033dda3f..59c9b7a1df4 100644
--- a/packages/snap-account-service/tsconfig.build.json
+++ b/packages/snap-account-service/tsconfig.build.json
@@ -6,15 +6,6 @@
     "rootDir": "./src"
   },
   "references": [
-    // READ THIS CAREFULLY:
-    // `account-tree-controller` is intentionally NOT referenced here to break
-    // a project-reference cycle:
-    //   account-tree-controller -> multichain-account-service
-    //                           -> snap-account-service
-    //                           -> account-tree-controller
-    // The types we'd otherwise pull from `@metamask/account-tree-controller`
-    // are mirrored locally in `./src/types.ts` — keep them in sync.
-    // { "path": "../account-tree-controller/tsconfig.build.json" },
     { "path": "../keyring-controller/tsconfig.build.json" },
     { "path": "../messenger/tsconfig.build.json" }
   ],
diff --git a/packages/snap-account-service/tsconfig.json b/packages/snap-account-service/tsconfig.json
index 4fd7b9ded3a..a0556a87d10 100644
--- a/packages/snap-account-service/tsconfig.json
+++ b/packages/snap-account-service/tsconfig.json
@@ -4,15 +4,6 @@
     "baseUrl": "./"
   },
   "references": [
-    // READ THIS CAREFULLY:
-    // `account-tree-controller` is intentionally NOT referenced here to break
-    // a project-reference cycle:
-    //   account-tree-controller -> multichain-account-service
-    //                           -> snap-account-service
-    //                           -> account-tree-controller
-    // The types we'd otherwise pull from `@metamask/account-tree-controller`
-    // are mirrored locally in `./src/types.ts` — keep them in sync.
-    // { "path": "../account-tree-controller" },
     { "path": "../keyring-controller" },
     { "path": "../messenger" }
   ],
diff --git a/yarn.lock b/yarn.lock
index df3259a1fd5..a54131389c2 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -8585,7 +8585,6 @@ __metadata:
   resolution: "@metamask/snap-account-service@workspace:packages/snap-account-service"
   dependencies:
     "@metamask/account-api": "npm:^1.0.4"
-    "@metamask/account-tree-controller": "npm:^7.5.5"
     "@metamask/auto-changelog": "npm:^6.1.0"
     "@metamask/eth-snap-keyring": "npm:^23.0.0"
     "@metamask/keyring-api": "npm:^23.5.0"