Skip to content

feat: Add CollapsibleSection#3952

Merged
FrederikBolding merged 3 commits intomainfrom
fb/collapsible-section
Apr 14, 2026
Merged

feat: Add CollapsibleSection#3952
FrederikBolding merged 3 commits intomainfrom
fb/collapsible-section

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented Apr 14, 2026

Add CollapsibleSection component, including structs, types etc.

https://consensyssoftware.atlassian.net/browse/WPC-959


Note

Medium Risk
Adds a new JSX element and wires it into core UI validation/allowed-element unions, which could affect interface creation/validation behavior and error messaging across Snaps UIs.

Overview
Adds a new CollapsibleSection JSX component (with label, optional isLoading/isExpanded, and layout props) and exports it as a first-class Snaps UI element.

Updates JSX validation to recognize and validate CollapsibleSection (including adding it to root/box child unions), adds component/struct test coverage, and adjusts the snap_createInterface invalid-param test expectation to include the new allowed UI type.

Reviewed by Cursor Bugbot for commit a7097d3. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.56%. Comparing base (c78b534) to head (a7097d3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3952   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         427      428    +1     
  Lines       12344    12348    +4     
  Branches     1939     1939           
=======================================
+ Hits        12167    12171    +4     
  Misses        177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding marked this pull request as ready for review April 14, 2026 10:40
@FrederikBolding FrederikBolding requested a review from a team as a code owner April 14, 2026 10:40
@FrederikBolding FrederikBolding added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit e7696aa Apr 14, 2026
129 checks passed
@FrederikBolding FrederikBolding deleted the fb/collapsible-section branch April 14, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants