fix: Allow name-lookup example to resolve on multiple chains#3953
Merged
FrederikBolding merged 1 commit intomainfrom Apr 14, 2026
Merged
fix: Allow name-lookup example to resolve on multiple chains#3953FrederikBolding merged 1 commit intomainfrom
FrederikBolding merged 1 commit intomainfrom
Conversation
Member
Author
|
@metamaskbot update-pr |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3953 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 427 427
Lines 12344 12344
Branches 1939 1939
=======================================
Hits 12167 12167
Misses 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow name-lookup example Snap to resolve on Sepolia and the
1337local chain used for E2E. This eases testing with it.Note
Low Risk
Manifest-only change that expands the allowed
endowment:name-lookupchain IDs for an example Snap; low risk aside from potentially affecting which networks the snap can resolve names on.Overview
Updates the name-lookup example Snap manifest to allow
endowment:name-lookupresolution on additional chains by expandingchainsfrom mainnet-only to include local E2E (eip155:1337) and Sepolia (eip155:11155111).Also updates the snap
source.shasumto match the new bundled output.Reviewed by Cursor Bugbot for commit 129a18b. Bugbot is set up for automated code reviews on this repo. Configure here.