Skip to content

ci: Error if no files found when uploading source artifacts#3958

Merged
FrederikBolding merged 1 commit intomainfrom
fb/ci-error-if-no-files-found
Apr 14, 2026
Merged

ci: Error if no files found when uploading source artifacts#3958
FrederikBolding merged 1 commit intomainfrom
fb/ci-error-if-no-files-found

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding commented Apr 14, 2026

We don't want to proceed with the next CI tasks if we cannot upload the artifacts required for them.


Note

Medium Risk
Tightens CI/release behavior by failing jobs when expected artifacts aren’t produced, which could surface previously hidden build issues and block downstream steps.

Overview
Ensures CI stops early if required build outputs aren’t present by setting if-no-files-found: error on key actions/upload-artifact steps.

This makes the build-lint-test workflow fail when it can’t upload the snaps-execution-environments build or overall build-source artifacts, and makes publish-release fail if release build artifacts aren’t generated.

Reviewed by Cursor Bugbot for commit 1b68b38. Bugbot is set up for automated code reviews on this repo. Configure here.

@FrederikBolding FrederikBolding requested a review from a team as a code owner April 14, 2026 15:06
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.47%. Comparing base (c339e31) to head (1b68b38).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3958      +/-   ##
==========================================
+ Coverage   98.56%   99.47%   +0.90%     
==========================================
  Files         428      261     -167     
  Lines       12348     7446    -4902     
  Branches     1939     1143     -796     
==========================================
- Hits        12171     7407    -4764     
+ Misses        177       39     -138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit a086680 Apr 14, 2026
173 of 178 checks passed
@FrederikBolding FrederikBolding deleted the fb/ci-error-if-no-files-found branch April 14, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants