From abcbe08b0ff35347edf7d98faa32ff83b624f9c6 Mon Sep 17 00:00:00 2001 From: Frederik Bolding Date: Fri, 8 May 2026 12:42:26 +0200 Subject: [PATCH 1/2] fix: Omit installing Snaps from getRunnableSnaps --- packages/snaps-controllers/src/snaps/SnapController.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/snaps-controllers/src/snaps/SnapController.ts b/packages/snaps-controllers/src/snaps/SnapController.ts index c1795d6eaf..3a009ed936 100644 --- a/packages/snaps-controllers/src/snaps/SnapController.ts +++ b/packages/snaps-controllers/src/snaps/SnapController.ts @@ -2575,7 +2575,11 @@ export class SnapController extends BaseController< * @returns All runnable snaps. */ getRunnableSnaps(): TruncatedSnap[] { - return getRunnableSnaps(this.getAllSnaps()); + return getRunnableSnaps( + Object.values(this.state.snaps) + .filter((snap) => snap.status !== SnapStatus.Installing) + .map(truncateSnap), + ); } /** From ba0faa05f338fb6114b1e989526966c6854e8ec7 Mon Sep 17 00:00:00 2001 From: Frederik Bolding Date: Fri, 8 May 2026 12:50:05 +0200 Subject: [PATCH 2/2] Move filter to getAllSnaps --- packages/snaps-controllers/src/snaps/SnapController.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/snaps-controllers/src/snaps/SnapController.ts b/packages/snaps-controllers/src/snaps/SnapController.ts index 3a009ed936..81afb51af7 100644 --- a/packages/snaps-controllers/src/snaps/SnapController.ts +++ b/packages/snaps-controllers/src/snaps/SnapController.ts @@ -2566,7 +2566,9 @@ export class SnapController extends BaseController< * @returns All installed snaps in their truncated format. */ getAllSnaps(): TruncatedSnap[] { - return Object.values(this.state.snaps).map(truncateSnap); + return Object.values(this.state.snaps) + .filter((snap) => snap.status !== SnapStatus.Installing) + .map(truncateSnap); } /** @@ -2575,11 +2577,7 @@ export class SnapController extends BaseController< * @returns All runnable snaps. */ getRunnableSnaps(): TruncatedSnap[] { - return getRunnableSnaps( - Object.values(this.state.snaps) - .filter((snap) => snap.status !== SnapStatus.Installing) - .map(truncateSnap), - ); + return getRunnableSnaps(this.getAllSnaps()); } /**