This repository was archived by the owner on Apr 22, 2024. It is now read-only.
chore: updating unproblematic dependencies#396
Closed
martinheidegger wants to merge 1 commit into
Closed
Conversation
httpJunkie
approved these changes
Jan 17, 2022
Contributor
|
Hi @martinheidegger, sorry for the delay in replying. This looks good to me — would you mind rebasing this? The checks on this need to be restarted and I can't seem to push to your branch. |
Contributor
|
Thank you for this pull request, but we are actively phasing out this package in favor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readable-streamupdated to @3 doesn't contain changes related to the only use I found.eth-rpc-errorsdoes not affect the usage.wsin version 8 were a bit too plentiful. Which is whywsis now only at v7, jumping over v6. Both releases are mostly maintenance releases with the Node version now requiring Node 6 (which is a requirement for other libraries too).ethereumjs-block(called@ethereumjs/blockfrom v3) which is why its only updated to version 2 in this PR.The dev dependencies,
browserify,eslintandtapehave both worked fine after the upgrade. This PR also removes theethjsdependency as it is unused.