This repository was archived by the owner on Apr 22, 2024. It is now read-only.
chore: updating to ethereumjs-util@6#399
Closed
martinheidegger wants to merge 1 commit into
Closed
Conversation
mcmire
reviewed
Apr 6, 2022
| @@ -1,4 +1,4 @@ | |||
| const sha3 = require('ethereumjs-util').sha3; | |||
| const keccak256 = require('ethereumjs-util').keccak256; | |||
Contributor
There was a problem hiding this comment.
This is a nitpick, feel free to take or leave, but it's probably more idiomatic to say this, yeah?
Suggested change
| const keccak256 = require('ethereumjs-util').keccak256; | |
| const { keccak256 } = require('ethereumjs-util') |
Contributor
|
This looks good — do you mind rebasing this? Hopefully it'll kick GH Actions to do its magic. |
Contributor
|
Thank you for this pull request, but we are actively phasing out this package in favor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating
ethereumjs-utilto its latest version@ethereumjs/utilv7 would require more effort. This PR limits the update to v6 which only required to renamesha3with 256bit tokeccak. In the tests the message had to also match the format in order to pass the new error sensibly triggered since6.2.0.