Skip to content
This repository was archived by the owner on Apr 22, 2024. It is now read-only.

chore: updating to ethereumjs-util@6#399

Closed
martinheidegger wants to merge 1 commit into
MetaMask:mainfrom
tradle:update/ethereumjs
Closed

chore: updating to ethereumjs-util@6#399
martinheidegger wants to merge 1 commit into
MetaMask:mainfrom
tradle:update/ethereumjs

Conversation

@martinheidegger
Copy link
Copy Markdown

Updating ethereumjs-util to its latest version @ethereumjs/util v7 would require more effort. This PR limits the update to v6 which only required to rename sha3 with 256bit to keccak. In the tests the message had to also match the format in order to pass the new error sensibly triggered since 6.2.0.

@martinheidegger martinheidegger requested a review from a team as a code owner January 17, 2022 15:22
@@ -1,4 +1,4 @@
const sha3 = require('ethereumjs-util').sha3;
const keccak256 = require('ethereumjs-util').keccak256;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nitpick, feel free to take or leave, but it's probably more idiomatic to say this, yeah?

Suggested change
const keccak256 = require('ethereumjs-util').keccak256;
const { keccak256 } = require('ethereumjs-util')

@mcmire
Copy link
Copy Markdown
Contributor

mcmire commented Apr 6, 2022

This looks good — do you mind rebasing this? Hopefully it'll kick GH Actions to do its magic.

@mcmire
Copy link
Copy Markdown
Contributor

mcmire commented Jan 4, 2023

Thank you for this pull request, but we are actively phasing out this package in favor of json-rpc-engine and its related packages, so I'm going to close this. As for the changes here, we no longer have an Etherscan-specific middleware, and one of the main packages in our ecosystem that accesses ethereumjs-util now is @metamask/eth-sig-util. We have since upgraded to using @ethereumjs/util there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants