Skip to content

Conversation

@akroshg
Copy link
Contributor

@akroshg akroshg commented Dec 11, 2018

akroshg and others added 5 commits December 10, 2018 10:52
In the loop range check we emit add instruction to add 1 to the range. That can overflow. We did't have overflow bailout over there.
Fixed that by adding bailout over there.
@wyrichte wyrichte self-requested a review December 11, 2018 19:22
Copy link
Contributor

@rajatd rajatd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chakrabot chakrabot merged commit c04787f into chakra-core:release/1.10 Dec 11, 2018
chakrabot pushed a commit that referenced this pull request Dec 11, 2018
chakrabot pushed a commit that referenced this pull request Dec 11, 2018
chakrabot pushed a commit that referenced this pull request Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants