Skip to content
This repository was archived by the owner on Nov 5, 2021. It is now read-only.

Improve tokenization of regular expressions#46

Merged
rebornix merged 2 commits intomicrosoft:masterfrom
spahnke:regex-flags
Oct 1, 2018
Merged

Improve tokenization of regular expressions#46
rebornix merged 2 commits intomicrosoft:masterfrom
spahnke:regex-flags

Conversation

@spahnke
Copy link
Contributor

@spahnke spahnke commented Oct 1, 2018

Hi,

this PR does three things

  1. Recognize s as a valid regular expression flag
  2. Tokenize the flag part of regular expressions as keyword.other like VS Code does
  3. Add more tests for regular expressions

Let me know what you think.

Thanks!

@msftclas
Copy link

msftclas commented Oct 1, 2018

CLA assistant check
All CLA requirements met.

@rebornix
Copy link
Member

rebornix commented Oct 1, 2018

@spahnke thanks for your contribution, it looks solid and helps me know more about the newly added regex flag https://tc39.github.io/ecma262/#sec-get-regexp.prototype.flags

@rebornix rebornix merged commit 66b5497 into microsoft:master Oct 1, 2018
@spahnke spahnke deleted the regex-flags branch October 2, 2018 14:53
@alexdima alexdima added this to the October 2018 milestone Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants