XS: secaudit issue #14

Patrick Soquet · Patrick Soquet · commit 46e0c276701c · 2021-11-29T10:05:33.000+01:00
diff --git a/xs/sources/xsDataView.c b/xs/sources/xsDataView.c
@@ -1942,7 +1942,7 @@ void fx_TypedArray_prototype_join(txMachine* the)
 	while (offset < limit) {
 		if (comma) {
 			slot = fxNextSlotProperty(the, slot, the->stack, XS_NO_ID, XS_NO_FLAG);
-			size += slot->value.key.sum;
+            size = fxAddChunkSizes(the, size, slot->value.key.sum);
 		}
 		else
 			comma = 1;

Original file line number	Diff line number	Diff line change
`@@ -1942,7 +1942,7 @@ void fx_TypedArray_prototype_join(txMachine* the)`
`1942`	`1942`	`while (offset < limit) {`
`1943`	`1943`	`if (comma) {`
`1944`	`1944`	`slot = fxNextSlotProperty(the, slot, the->stack, XS_NO_ID, XS_NO_FLAG);`
`1945`		`- size += slot->value.key.sum;`
	`1945`	`+ size = fxAddChunkSizes(the, size, slot->value.key.sum);`
`1946`	`1946`	`}`
`1947`	`1947`	`else`
`1948`	`1948`	`comma = 1;`