XS: fix array flat/sort stack overflows

Patrick Soquet · Patrick Soquet · commit 73aad47b3eb5 · 2026-01-20T10:02:01.000+01:00
diff --git a/xs/sources/xsArray.c b/xs/sources/xsArray.c
@@ -915,6 +915,7 @@ void fxSortArrayItems(txMachine* the, txSlot* function, txSlot* array, txNumber
 		while (index < LENGTH) {
 			mxPushSlot(target);
 			mxDeleteIndex(index);
+			mxPop();
 			index++;
 		}
 		mxPop();
@@ -1773,6 +1774,7 @@ txIndex fx_Array_prototype_flatAux(txMachine* the, txSlot* source, txIndex lengt
 			else {
 				mxPushSlot(mxResult);
 				mxDefineIndex(start, 0, XS_GET_ONLY);
+				mxPop();
 				start++;
 			}
 		}
diff --git a/xs/sources/xsmc.c b/xs/sources/xsmc.c
@@ -154,6 +154,7 @@ void _xsDelete(txMachine *the, txSlot *self, txID id)
 	mxOverflow(-1);
 	fxPush(*self);
 	mxDeleteID(id);
+	mxPop();
 }
 
 void _xsDeleteAt(txMachine *the, txSlot *self, txSlot *at)
@@ -162,6 +163,7 @@ void _xsDeleteAt(txMachine *the, txSlot *self, txSlot *at)
 	fxPush(*self);
 	fxPush(*at);
 	fxDeleteAt(the);
+	mxPop();
 }
 
 void _xsCall(txMachine *the, txSlot *res, txSlot *self, txUnsigned id, ...)

Original file line number	Diff line number	Diff line change
`@@ -915,6 +915,7 @@ void fxSortArrayItems(txMachine* the, txSlot* function, txSlot* array, txNumber`
`915`	`915`	`while (index < LENGTH) {`
`916`	`916`	`mxPushSlot(target);`
`917`	`917`	`mxDeleteIndex(index);`
	`918`	`+ mxPop();`
`918`	`919`	`index++;`
`919`	`920`	`}`
`920`	`921`	`mxPop();`
`@@ -1773,6 +1774,7 @@ txIndex fx_Array_prototype_flatAux(txMachine* the, txSlot* source, txIndex lengt`
`1773`	`1774`	`else {`
`1774`	`1775`	`mxPushSlot(mxResult);`
`1775`	`1776`	`mxDefineIndex(start, 0, XS_GET_ONLY);`
	`1777`	`+ mxPop();`
`1776`	`1778`	`start++;`
`1777`	`1779`	`}`
`1778`	`1780`	`}`
Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,7 @@ void _xsDelete(txMachine the, txSlot self, txID id)`
`154`	`154`	`mxOverflow(-1);`
`155`	`155`	`fxPush(*self);`
`156`	`156`	`mxDeleteID(id);`
	`157`	`+ mxPop();`
`157`	`158`	`}`
`158`	`159`
`159`	`160`	`void _xsDeleteAt(txMachine the, txSlot self, txSlot *at)`
`@@ -162,6 +163,7 @@ void _xsDeleteAt(txMachine the, txSlot self, txSlot *at)`
`162`	`163`	`fxPush(*self);`
`163`	`164`	`fxPush(*at);`
`164`	`165`	`fxDeleteAt(the);`
	`166`	`+ mxPop();`
`165`	`167`	`}`
`166`	`168`
`167`	`169`	`void _xsCall(txMachine the, txSlot res, txSlot *self, txUnsigned id, ...)`