Skip to content

Commit bd2cf28

Browse files
rwaldronmkellner
authored andcommitted
Ensure that "Versions: SDK & XS" are populated with valid data. Fixes gh-6 #7
1 parent 845a88b commit bd2cf28

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

tools/mcconfig/make.esp.mk

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020
ESP_BASE ?= $(HOME)/esp
2121
HOST_OS := $(shell uname)
2222

23-
ARDUINO_ROOT ?= $(ESP_BASE)/esp8266-2.3.0
23+
XS_GIT_VERSION ?= $(shell git -C $(MODDABLE) describe --tags --always --dirty 2>/dev/null)
24+
ESP_SDK_RELEASE ?= esp8266-2.3.0
25+
ARDUINO_ROOT ?= $(ESP_BASE)/$(ESP_SDK_RELEASE)
2426
ESPRESSIF_SDK_ROOT ?= $(ESP_BASE)/ESP8266_RTOS_SDK
2527
ESP_TOOLS_SDK_ROOT = $(ARDUINO_ROOT)/tools/sdk
2628
ARDUINO_ESP8266 = $(ARDUINO_ROOT)/cores/esp8266
@@ -248,9 +250,6 @@ ifneq ($(shell grep $(LD_STD_CPP) $(ARDUINO_ROOT)/platform.txt),)
248250
endif
249251

250252
# Utility functions
251-
git_description = $(shell git -C $(1) describe --tags --always --dirty 2>/dev/null)
252-
SRC_GIT_VERSION = $(call git_description,$(ESP_BASE)/sources)
253-
ESP_GIT_VERSION = $(call git_description,$(ARDUINO_ROOT))
254253
time_string = $(shell perl -e 'use POSIX qw(strftime); print strftime($(1), localtime());')
255254
BUILD_DATE = $(call time_string,"%Y-%m-%d")
256255
BUILD_TIME = $(call time_string,"%H:%M:%S")
@@ -300,14 +299,14 @@ $(LIB_DIR):
300299
$(BIN_DIR)/main.bin: $(SDK_OBJ) $(LIB_DIR)/lib_a-setjmp.o $(XS_OBJ) $(TMP_DIR)/mc.xs.c.o $(TMP_DIR)/mc.resources.c.o $(OBJECTS)
301300
@echo "# ld main.bin"
302301
echo '#include "buildinfo.h"' > $(LIB_DIR)/buildinfo.cpp
303-
echo '_tBuildInfo _BuildInfo = {"$(BUILD_DATE)","$(BUILD_TIME)","$(SRC_GIT_VERSION)","$(ESP_GIT_VERSION)"};' >> $(LIB_DIR)/buildinfo.cpp
302+
echo '_tBuildInfo _BuildInfo = {"$(BUILD_DATE)","$(BUILD_TIME)","$(XS_GIT_VERSION)","$(ESP_GIT_VERSION)"};' >> $(LIB_DIR)/buildinfo.cpp
304303
$(CPP) $(C_DEFINES) $(C_INCLUDES) $(CPP_FLAGS) $(LIB_DIR)/buildinfo.cpp -o $(LIB_DIR)/buildinfo.cpp.o
305304
$(LD) $(LD_FLAGS) -Wl,--start-group $^ $(LIB_DIR)/buildinfo.cpp $(LD_STD_LIBS) -Wl,--end-group -L$(LIB_DIR) -o $(TMP_DIR)/main.elf
306305
$(TOOLS_BIN)/xtensa-lx106-elf-objdump -t $(TMP_DIR)/main.elf > $(BIN_DIR)/main.sym
307306
$(ESPTOOL) -eo $(ARDUINO_ROOT)/bootloaders/eboot/eboot.elf -bo $@ -bm $(FLASH_MODE) -bf $(FLASH_SPEED) -bz $(FLASH_SIZE) -bs .text -bp 4096 -ec -eo $(TMP_DIR)/main.elf -bs .irom0.text -bs .text -bs .data -bs .rodata -bc -ec
308307
@echo "# Versions"
309-
@echo "# SDK: $(ESP_GIT_VERSION)"
310-
@echo "# XS: $(SRC_GIT_VERSION)"
308+
@echo "# ESP: $(ESP_SDK_RELEASE)"
309+
@echo "# XS: $(XS_GIT_VERSION)"
311310
@$(TOOLS_BIN)/xtensa-lx106-elf-size -A $(TMP_DIR)/main.elf | perl -e $(MEM_USAGE)
312311

313312
$(LIB_DIR)/lib_a-setjmp.o: $(ESPRESSIF_SDK_ROOT)/lib/libcirom.a

0 commit comments

Comments
 (0)