Add workflow artifact upload and improve ddb-publish bundle resolution

Author: m-houston

.github/workflows/stage-3-build.yaml

@@ -54,11 +54,18 @@ jobs:
         uses: actions/checkout@v4
 
       - name: "Bundle ddb-publish"
+        id: bundle
         uses: ./.github/actions/bundle-ddb-publish
         with:
           node-version: "${{ inputs.nodejs_version }}"
           run-typecheck: "false"
 
+      - name: "Upload bundle as workflow artifact"
+        uses: actions/upload-artifact@v4
+        with:
+          name: ddb-publish-bundle
+          path: "${{ steps.bundle.outputs.tarball-path }}"
+
   artefact-1:
     name: "Artefact 1"
     runs-on: ubuntu-latest

actions/ddb-publish/action.yml

@@ -24,34 +24,82 @@ inputs:
 runs:
   using: "composite"
   steps:
-    - name: Download ddb-publish bundle from release
+    - name: Resolve and download ddb-publish bundle
       shell: bash
       env:
         GH_TOKEN: ${{ github.token }}
-        RELEASE_TAG: ${{ github.action_ref }}
-        ASSET_NAME: ddb-publish-bundle.tgz
+        REPO: ${{ github.repository }}
+        ACTION_REF: ${{ github.action_ref }}
+        RELEASE_ASSET_NAME: ddb-publish-bundle.tgz
+        WORKFLOW_ARTIFACT_NAME: ddb-publish-bundle
       run: |
         set -euo pipefail
 
-        if [[ "${RELEASE_TAG}" == "" ]]; then
-          echo "ERROR: github.action_ref is empty; can't determine which release asset to download." >&2
+        download_dir="${RUNNER_TEMP}/ddb-publish"
+        unpack_dir="${download_dir}/unpacked"
+
+        mkdir -p "${download_dir}" "${unpack_dir}"
+
+        echo "[ddb-publish] repo=${REPO}"
+        echo "[ddb-publish] action_ref=${ACTION_REF:-<empty>}"
+
+        if [[ -z "${ACTION_REF}" ]]; then
+          echo "ERROR: github.action_ref is empty; unable to locate release asset or branch artifact." >&2
           exit 1
         fi
 
-        # GitHub provides a temporary token by default; no extra PAT needed.
-        gh release download "${RELEASE_TAG}" --repo "${GITHUB_REPOSITORY}" --pattern "${ASSET_NAME}" --dir "${RUNNER_TEMP}/ddb-publish"
+        # Prefer release assets when the action ref is a tag with a matching release.
+        if gh release view "${ACTION_REF}" --repo "${REPO}" >/dev/null 2>&1; then
+          echo "[ddb-publish] Found release for ref '${ACTION_REF}'. Downloading release asset '${RELEASE_ASSET_NAME}'."
+          gh release download "${ACTION_REF}" --repo "${REPO}" --pattern "${RELEASE_ASSET_NAME}" --dir "${download_dir}"
+          tar -xzf "${download_dir}/${RELEASE_ASSET_NAME}" -C "${unpack_dir}"
+          echo "[ddb-publish] Bundle extracted from release asset."
+          exit 0
+        fi
+
+        # Otherwise treat the ref as a branch-like ref and fetch the latest successful CI artifact.
+        branch="${ACTION_REF#refs/heads/}"
+        echo "[ddb-publish] No release found for ref '${ACTION_REF}'. Falling back to latest workflow artifact on branch '${branch}'."
+
+        run_id="$(gh run list \
+          --repo "${REPO}" \
+          --workflow "stage-3-build.yaml" \
+          --branch "${branch}" \
+          --status success \
+          --json databaseId \
+          --jq '.[0].databaseId')"
 
-        mkdir -p "${RUNNER_TEMP}/ddb-publish/unpacked"
-        tar -xzf "${RUNNER_TEMP}/ddb-publish/${ASSET_NAME}" -C "${RUNNER_TEMP}/ddb-publish/unpacked"
+        if [[ -z "${run_id}" || "${run_id}" == "null" ]]; then
+          echo "ERROR: Could not find a successful 'stage-3-build.yaml' run for branch '${branch}' to download artifact '${WORKFLOW_ARTIFACT_NAME}'." >&2
+          exit 1
+        fi
+
+        echo "[ddb-publish] Downloading artifact '${WORKFLOW_ARTIFACT_NAME}' from workflow run ${run_id}."
+        gh run download "${run_id}" --repo "${REPO}" --name "${WORKFLOW_ARTIFACT_NAME}" --dir "${download_dir}"
+
+        tarball_path="${download_dir}/${RELEASE_ASSET_NAME}"
+        if [[ ! -f "${tarball_path}" ]]; then
+          echo "ERROR: Downloaded artifact did not contain expected tarball '${RELEASE_ASSET_NAME}'." >&2
+          ls -la "${download_dir}" >&2
+          exit 1
+        fi
+
+        tar -xzf "${tarball_path}" -C "${unpack_dir}"
+        echo "[ddb-publish] Bundle extracted from workflow artifact."
 
     - name: Run publisher
       shell: bash
       run: |
         set -euo pipefail
 
+        echo "[ddb-publish] Starting publish run"
+        echo "[ddb-publish] source='${{ inputs.source-path }}' env='${{ inputs.target-env }}' table='${{ inputs.table-name }}' force='${{ inputs.force }}' dry-run='${{ inputs.dry-run }}'"
+
         node "${RUNNER_TEMP}/ddb-publish/unpacked/index.cjs" \
           --source "${{ inputs.source-path }}" \
           --env "${{ inputs.target-env }}" \
           --table "${{ inputs.table-name }}" \
           $([[ "${{ inputs.force }}" == "true" ]] && echo "--force") \
           $([[ "${{ inputs.dry-run }}" == "true" ]] && echo "--dry-run")
+
+        echo "[ddb-publish] Publish run completed"