Fix new compiler warning failures

[cliffburdick]

No description provided.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[cliffburdick]

/build

[greptile-apps]

Greptile Summary

This PR silences new compiler warning failures triggered by nvc++ and other compilers across three files, with no logic changes.

• CMakeLists.txt: adds --diag_suppress,if_consteval_in_nonconstexpr_function only for CUDA TUs when using nvc++, targeting a known libcudacxx incompatibility.
• pybind.h: adds [[maybe_unused]] to valid_size, which becomes unused when MATX_ASSERT_STR is compiled out in NDEBUG builds.
• sar_bp.cuh: introduces an explicitly-typed strict_compute_t phase variable to avoid implicit narrowing from the multiplication result to sincosf's float argument.

Confidence Score: 5/5

All three changes are narrow warning suppressions that do not alter runtime behavior; safe to merge.

Each fix is minimal and targeted: the CMake suppression is correctly scoped to CUDA TUs under nvc++, the [[maybe_unused]] annotation matches the well-known NDEBUG/assert pattern, and the explicit static_cast in the SAR kernel preserves the existing floating-point semantics while making the type conversion explicit. No logic is changed in any file.

No files require special attention.

Important Files Changed

Filename	Overview
CMakeLists.txt	Adds nvc++ else branch to suppress if_consteval_in_nonconstexpr_function diagnostic for CUDA compilation; uses correct generator-expression scoping so it only applies to CUDA TUs.
include/matx/core/pybind.h	Annotates valid_size with [[maybe_unused]] to suppress the unused-variable warning emitted when MATX_ASSERT_STR compiles away in NDEBUG builds; the variable is still read in debug builds.
include/matx/kernels/sar_bp.cuh	Hoists phase_correction_partial * range_delta into an explicitly-typed strict_compute_t phase variable to avoid implicit narrowing-conversion warnings when the product type differs from the sincosf argument type.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Compiler Warning Failures] --> B{Compiler type?}
    B -->|nvc++| C[CMakeLists.txt\nSuppress if_consteval_in_nonconstexpr_function\nfor CUDA translation units only]
    B -->|Any compiler| D[pybind.h\nAdd maybe_unused to valid_size\nsilences unused-var in NDEBUG builds]
    B -->|Any compiler| E[sar_bp.cuh\nHoist phase_correction_partial * range_delta\ninto explicit strict_compute_t phase\nremoves narrowing-conversion warning]
    C --> F[Warnings resolved]
    D --> F
    E --> F

Loading

_{Reviews (1): Last reviewed commit: "Fix new compiler warning failures" | Re-trigger Greptile}

[coveralls]

Coverage is 93.573% — cburdick/fix-new-compiler-warnings into main. No base build found for main.