Skip to content

Commit 41188db

Browse files
fix greptile general review issues by changing Pyimpetus handling
1 parent ce1e8bc commit 41188db

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

nvflare/app_opt/feature_election/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -334,6 +334,8 @@ logging.basicConfig(level=logging.DEBUG)
334334

335335
```bash
336336
pytest tests/unit_test/app_opt/feature_election/test.py -v
337+
```
338+
337339
## Support
338340

339341
- **FLASH Repository**: [GitHub](https://github.com/parasecurity/FLASH)

nvflare/app_opt/feature_election/executor.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,10 @@ def perform_feature_selection(self) -> Tuple[np.ndarray, np.ndarray]:
283283
mask[np.argsort(scores)[-k:]] = True
284284
return mask, scores
285285

286-
model = PPIMBC(self.fs_params.get("model", LogisticRegression(max_iter=1000, random_state=42)))
286+
# Extract base model separately, then forward remaining fs_params as kwargs
287+
base_model = self.fs_params.get("model", LogisticRegression(max_iter=1000, random_state=42))
288+
ppimbc_kwargs = {k: v for k, v in self.fs_params.items() if k != "model"}
289+
model = PPIMBC(base_model, **ppimbc_kwargs)
287290
selected_features = model.fit(self.X_train, self.y_train)
288291
mask = np.zeros(n_features, dtype=bool)
289292
mask[selected_features] = True

0 commit comments

Comments
 (0)