From df44d25b25250b7b8f203ef88c87ac884922a7b1 Mon Sep 17 00:00:00 2001 From: JunyiXu-nv <219237550+JunyiXu-nv@users.noreply.github.com> Date: Mon, 20 Jul 2026 12:44:59 +0000 Subject: [PATCH 1/2] [https://nvbugs/6480574][fix] seed attrs bypassed by __new__ in pool session shutdown test test_pool_session_shutdown_never_blocks_after_release constructs a MpiPoolSession with __new__() and only sets mpi_pool, then calls release_exit_joins() and shutdown(). MpiPoolSession.shutdown() reads self.n_workers (log line) and self._wait_shutdown (post-shutdown worker barrier); on the raw-constructed session both are absent and the second attribute access raises AttributeError before the code under test runs. Seed the two attributes on the mock session so the test exercises the release/shutdown contract instead of failing on attribute lookup. Keep _wait_shutdown=False because the test targets the blocking-join guard, not the identity-based worker-exit wait. Signed-off-by: JunyiXu-nv <219237550+JunyiXu-nv@users.noreply.github.com> --- tests/unittest/executor/test_proxy_fast_death.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/unittest/executor/test_proxy_fast_death.py b/tests/unittest/executor/test_proxy_fast_death.py index df9756307917..0032bc393cd2 100644 --- a/tests/unittest/executor/test_proxy_fast_death.py +++ b/tests/unittest/executor/test_proxy_fast_death.py @@ -524,6 +524,14 @@ def test_pool_session_shutdown_never_blocks_after_release(): pool = _Mock() pool._pool.thread = None # no real manager thread to deregister session.mpi_pool = pool + # __init__ is bypassed above; seed the attributes that shutdown() reads + # so the test exercises the release/shutdown contract, not attribute + # lookup on a raw-constructed session. Keep them minimal: + # * n_workers is only used by shutdown()'s log line. + # * _wait_shutdown gates the post-shutdown worker-exit barrier; + # the test targets the blocking-join guard, so leave it off. + session.n_workers = 1 + session._wait_shutdown = False session.release_exit_joins() session.shutdown() # owner asks for the default blocking shutdown From 1571acd99f0b991bb17c4c9c4b313261a2b912eb Mon Sep 17 00:00:00 2001 From: JunyiXu-nv <219237550+JunyiXu-nv@users.noreply.github.com> Date: Tue, 21 Jul 2026 10:38:42 +0000 Subject: [PATCH 2/2] [https://nvbugs/6480574][chore] unwaive test_pool_session_shutdown_never_blocks_after_release The test now seeds the attributes that MpiPoolSession.shutdown() reads, so the AttributeError raised on the raw-constructed session is gone and the test passes. Remove the waive. Signed-off-by: JunyiXu-nv <219237550+JunyiXu-nv@users.noreply.github.com> --- tests/integration/test_lists/waives.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/integration/test_lists/waives.txt b/tests/integration/test_lists/waives.txt index ac2ded84fd37..7e92cea4df57 100644 --- a/tests/integration/test_lists/waives.txt +++ b/tests/integration/test_lists/waives.txt @@ -414,7 +414,6 @@ unittest/_torch/visual_gen/test_attention_integration.py::test_sage_attention_se unittest/_torch/visual_gen/test_attention_integration.py::test_sage_attention_self_attention[int8-2-1560] SKIP (https://nvbugs/6198760) unittest/auto_deploy/multigpu/custom_ops SKIP (https://nvbugs/6403920) unittest/disaggregated/test_kv_transfer.py::test_transfer_worker_v2[tp4_pp1_to_tp2_pp2] SKIP (https://nvbugs/6426834) -unittest/executor/test_proxy_fast_death.py::test_pool_session_shutdown_never_blocks_after_release SKIP (https://nvbugs/6480574) unittest/executor/test_rpc.py::TestRpcCorrectness::test_incremental_task_async SKIP (https://nvbugs/5741476) unittest/executor/test_rpc_proxy.py SKIP (https://nvbugs/5605741) unittest/executor/test_rpc_worker.py SKIP (https://nvbugs/5605741)