Use public API instead of removed private function in te_llama.py#1856
Merged
Conversation
* replaced use of _load_state_dict_into_model with model.load_state_dict because the private function _load_state_dict_into_model was removed in huggingface/transformers#36335 Signed-off-by: Jan Bielak <jbielak@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced use of
_load_state_dict_into_modelwithmodel.load_state_dictbecause the private function_load_state_dict_into_modelwas removed in huggingface/transformers#36335.Without this fix, the example no longer works with the most recent version of Hugging Face Transformers.
Type of change
Changes
_load_state_dict_into_modelwithmodel.load_state_dictbecause the private function_load_state_dict_into_modelwas removed in Update form pretrained to make TP a first class citizen huggingface/transformers#36335Checklist: