Update supervisord before stop; don't fetch timestamps when dhcp is not running#559
Merged
Merged
Conversation
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-03-13 17:30:06 UTC | Commit: 9b149b9 |
🛡️ Vulnerability Scan🚨 Found 74 vulnerability(ies) Severity Breakdown:
🔗 View full details in Security tab 🕐 Last updated: 2026-03-13 17:30:09 UTC | Commit: 9b149b9 |
rwthompsonii
approved these changes
Mar 13, 2026
abvarshney-nv
approved these changes
Mar 16, 2026
ajf
pushed a commit
to ajf/infra-controller
that referenced
this pull request
Mar 19, 2026
…ot running (NVIDIA#559) adds "update" to the stop command. This makes sure that supervisord knows about the dhcp server config before the stop is issued. this is important on newly provisioned DPUs since the dhcp server config doesn't exist initially. Also stops fetching the timestamps when dhcp is not running to avoiding noise in the logs <!-- Describe what this PR does --> <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [X] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) <!-- If applicable, provide GitHub Issue. --> - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [X] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) <!-- Any additional context, deployment notes, or reviewer guidance -->
srinivasadmurthy
pushed a commit
to srinivasadmurthy/bare-metal-manager-core
that referenced
this pull request
Mar 20, 2026
…ot running (NVIDIA#559) adds "update" to the stop command. This makes sure that supervisord knows about the dhcp server config before the stop is issued. this is important on newly provisioned DPUs since the dhcp server config doesn't exist initially. Also stops fetching the timestamps when dhcp is not running to avoiding noise in the logs ## Description <!-- Describe what this PR does --> ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [X] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [X] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> Signed-off-by: Srinivasa Murthy <srmurthy@nvidia.com>
nvcoop
pushed a commit
that referenced
this pull request
Apr 9, 2026
…ot running (#559) adds "update" to the stop command. This makes sure that supervisord knows about the dhcp server config before the stop is issued. this is important on newly provisioned DPUs since the dhcp server config doesn't exist initially. Also stops fetching the timestamps when dhcp is not running to avoiding noise in the logs ## Description <!-- Describe what this PR does --> ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [X] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Related Issues (Optional) <!-- If applicable, provide GitHub Issue. --> ## Breaking Changes - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> ## Testing <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [X] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance -->
ajf
pushed a commit
to ajf/infra-controller
that referenced
this pull request
Jun 1, 2026
Signed-off-by: Chet Nichols III <chetn@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds "update" to the stop command. This makes sure that supervisord knows about the dhcp server config before the stop is issued. this is important on newly provisioned DPUs since the dhcp server config doesn't exist initially.
Also stops fetching the timestamps when dhcp is not running to avoiding noise in the logs
Description
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes