Reapply multi-DPU admin IP change#634
Merged
Merged
Conversation
…er configuration (NVIDIA#457)" This reverts commit 9f3c2da.
…N_DROP_PREFIX_LIST (NVIDIA#538)" This reverts commit bc7caa2.
…ot running (NVIDIA#559) adds "update" to the stop command. This makes sure that supervisord knows about the dhcp server config before the stop is issued. this is important on newly provisioned DPUs since the dhcp server config doesn't exist initially. Also stops fetching the timestamps when dhcp is not running to avoiding noise in the logs <!-- Describe what this PR does --> <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [X] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) <!-- If applicable, provide GitHub Issue. --> - [ ] This PR contains breaking changes <!-- If checked above, describe the breaking changes and migration steps --> <!-- How was this tested? Check all that apply --> - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [X] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) <!-- Any additional context, deployment notes, or reviewer guidance -->
Closed
10 tasks
wminckler
approved these changes
Mar 19, 2026
ajf
commented
Mar 19, 2026
| dpu_extension_services: vec![], | ||
| }; | ||
|
|
||
| let mut last_dhcp_requests = vec![]; |
Collaborator
Author
There was a problem hiding this comment.
This was a conflict, doesn't show up in your original commit of 56d6a51
Contributor
There was a problem hiding this comment.
there were changes to last_dhcp_timestamps in main for DPF. let me go through them
Contributor
There was a problem hiding this comment.
fixed. the change here is just to move the get timestamp code down after getting the config. The conflict was because the get timestamp code was refactored in main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reapplies previously reverted commits to fix admin IP on secondary DPUs