Skip to content

Update notebook environment to python 3.10#326

Merged
mdeceglie merged 7 commits into
masterfrom
pyversion
Jul 1, 2022
Merged

Update notebook environment to python 3.10#326
mdeceglie merged 7 commits into
masterfrom
pyversion

Conversation

@kandersolar
Copy link
Copy Markdown
Member

@kandersolar kandersolar commented Apr 27, 2022

  • [ ] Code changes are covered by tests
  • [ ] Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • [ ] New functions added to __init__.py
  • [ ] API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

See #319

@kandersolar kandersolar added the dependencies Pull requests that update a dependency file label Apr 27, 2022
@kandersolar kandersolar changed the base branch from master to development April 27, 2022 20:42
@mikofski
Copy link
Copy Markdown
Contributor

😮 RdTools at the bleeding edge!

@kandersolar
Copy link
Copy Markdown
Member Author

😮 RdTools at the bleeding edge!

Not quite, they're already up to 3.11.0a7 😄 By the way, 3.11 will have some cool improvements, check it out: https://docs.python.org/3.11/whatsnew/3.11.html

@kandersolar kandersolar changed the title [WIP] Update notebook environment to python 3.10 Update notebook environment to python 3.10 May 17, 2022
@kandersolar kandersolar marked this pull request as ready for review May 17, 2022 15:54
@mdeceglie
Copy link
Copy Markdown
Collaborator

I suggest we update the notes at the top of each example to say python 3.10 instead of 3.7? Also there is a note about 3.7 and examples on the RTD index page.

Should we also re-run degradation_and_soiling_example.ipynb?

Copy link
Copy Markdown
Member Author

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good points, addressed.

------------
* Upgrade the notebook environment from python 3.7 to python 3.10.
Several dependency versions in ``docs/notebook_requirements.txt`` are
updated as well. (:issue:`319`, :pull:`326`)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anticipating some additional dependabot PRs before the next release, I thought we might leave this as a placeholder and clean up these requirements.txt change descriptions later.

@kandersolar kandersolar changed the base branch from development to master June 28, 2022 21:42
Copy link
Copy Markdown
Collaborator

@mdeceglie mdeceglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdeceglie mdeceglie merged commit a997cf7 into master Jul 1, 2022
@mdeceglie mdeceglie deleted the pyversion branch July 1, 2022 21:13
@kandersolar kandersolar mentioned this pull request Sep 13, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants