remove duplicate plugins data#5563
Merged
rigor789 merged 2 commits intoNativeScript:masterfrom Aug 23, 2021
Merged
Conversation
This happens when multiple deps have another common dependencies. This fix has one direct consequences which makes app build faster. Before this native plugins where built multiple times. As an example for [this](https://github.com/nativescript-community/ui-material-components/tree/master/demo-vue) app using my material components. Before this commit : ```js pluginsData 37 [ '@nativescript-community/css-theme', '@nativescript-community/text', '@nativescript-community/ui-material-activityindicator', '@nativescript-community/ui-material-bottom-navigation', '@nativescript-community/ui-material-bottomnavigationbar', '@nativescript-community/ui-material-bottomsheet', '@nativescript-community/ui-material-button', '@nativescript-community/ui-material-cardview', '@nativescript-community/ui-material-core', '@nativescript-community/ui-material-dialogs', '@nativescript-community/ui-material-floatingactionbutton', '@nativescript-community/ui-material-progress', '@nativescript-community/ui-material-ripple', '@nativescript-community/ui-material-slider', '@nativescript-community/ui-material-snackbar', '@nativescript-community/ui-material-speeddial', '@nativescript-community/ui-material-tabs', '@nativescript-community/ui-material-textfield', '@nativescript-community/ui-material-textview', '@nativescript/core', '@nativescript/iqkeyboardmanager', '@nativescript/theme', 'nativescript-vue', '@nativescript-community/ui-material-core', '@nativescript-community/ui-material-core', '@nativescript-community/ui-material-core', '@nativescript-community/ui-material-core', '@nativescript-community/text', '@nativescript-community/ui-material-core', '@nativescript-community/ui-material-core', '@nativescript-community/ui-material-core', '@nativescript-community/ui-material-textfield', '@nativescript-community/ui-material-core', '@nativescript-community/ui-material-core', '@nativescript-community/text', '@nativescript-community/ui-material-core', '@nativescript-community/text' ] ``` After this plugin: ```js pluginsData 23 [ '@nativescript-community/css-theme', '@nativescript-community/text', '@nativescript-community/ui-material-activityindicator', '@nativescript-community/ui-material-bottom-navigation', '@nativescript-community/ui-material-bottomnavigationbar', '@nativescript-community/ui-material-bottomsheet', '@nativescript-community/ui-material-button', '@nativescript-community/ui-material-cardview', '@nativescript-community/ui-material-core', '@nativescript-community/ui-material-dialogs', '@nativescript-community/ui-material-floatingactionbutton', '@nativescript-community/ui-material-progress', '@nativescript-community/ui-material-ripple', '@nativescript-community/ui-material-slider', '@nativescript-community/ui-material-snackbar', '@nativescript-community/ui-material-speeddial', '@nativescript-community/ui-material-tabs', '@nativescript-community/ui-material-textfield', '@nativescript-community/ui-material-textview', '@nativescript/core', '@nativescript/iqkeyboardmanager', '@nativescript/theme', 'nativescript-vue' ] ``` It means the native build of the app plugins got reduced by 60%
rigor789
approved these changes
Aug 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens when multiple deps have another common dependencies.
This fix has one direct consequences which makes app build faster.
Before this native plugins where built multiple times.
As an example for this app using my material components.
Before this commit :
After this plugin:
It means the native build of the app plugins got reduced by 60%
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].