fix(ios-publish): accept body on http post and update to new api#5580
Merged
rigor789 merged 3 commits intoNativeScript:masterfrom Sep 30, 2021
Merged
fix(ios-publish): accept body on http post and update to new api#5580rigor789 merged 3 commits intoNativeScript:masterfrom
rigor789 merged 3 commits intoNativeScript:masterfrom
Conversation
rigor789
approved these changes
Sep 30, 2021
Member
rigor789
left a comment
rigor789
left a comment
There was a problem hiding this comment.
lgtm, just small change to simplify logic in http-client
rigor789
approved these changes
Sep 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
With 8.1 cli
ns publish iosresulted in 401In previous cli versions it resulted in 404 because the endpoint for changing the team was removed by apple.
What is the new behavior?
ns publish ios --appleApplicationSpecificPassword ...ns appstorenow both work.
Fixes/Implements/Closes #5553.