New spectate commands (#1611)

* init

* find player client side

* commands to select players and spectate the selected player

* example config, spectate left right of current spectate target

* fastest player

* add last hurt/shooter/event/attacker/killer/ghoster commands and move all command checks to neo_player

* added some more comands to the example config, changed observer mode for recent commands if player not in a observer mode that follows the player

* cleanup

* make and sort the list regardless, just write down all the possible commands, this config is meant to be copied and changed

Author: AdamTadeusz

game/neo/cfg/exampleSpectatorConfig.cfg

@@ -0,0 +1,33 @@
+// set the following to ensure players dont move around the hud when changing star or class or dying
+// cl_neo_squad_hud_sort_players_by_class_alive_and_star to 0
+
+bind 1 "spec_player_by_hud_position 0"
+bind 2 "spec_player_by_hud_position 1"
+bind 3 "spec_player_by_hud_position 2"
+bind 4 "spec_player_by_hud_position 3"
+bind 5 "spec_player_by_hud_position 4"
+bind 6 "spec_player_by_hud_position 5"
+bind 7 "spec_player_by_hud_position 6"
+bind 8 "spec_player_by_hud_position 7"
+bind 9 "spec_player_by_hud_position 8"
+bind 0 "spec_player_by_hud_position 9"
+
+// The following do not make much sense in the old hud
+// cl_neo_squad_hud_original 0
+
+bind mwheelup select_next_alive_player_in_hud
+bind mwheeldown select_previous_alive_player_in_hud
+bind mouse3 spectate_player_selected_in_hud
+// Ideally these replace spec_next and spec_previous
+bind mouse2 spec_next_entity_in_hud
+bind mouse1 spec_previous_entity_in_hud
+
+bind mouse5 spec_player_under_mouse
+bind mouse4 spec_fastest_player
+
+bind i spec_last_event 
+bind o spec_last_hurt
+bind p spec_last_shooter
+bind j spec_last_attacker
+bind k spec_last_killer
+bind l spec_last_ghoster

src/game/client/c_baseplayer.cpp

@@ -736,7 +736,12 @@ bool C_BasePlayer::IsValidObserverTarget(CBaseEntity* target)
 
 	if (player->m_lifeState == LIFE_DEAD || player->m_lifeState == LIFE_DYING)
 	{
+#ifdef NEO
+		constexpr int DEATH_SPEC_TIME = 3.0f; // OGNT switches spectator targets much faster than the DEATH_ANIMATION_TIME
+		if ((player->m_flDeathTime + DEATH_SPEC_TIME) < gpGlobals->curtime)
+#else
 		if ((player->m_flDeathTime + DEATH_ANIMATION_TIME) < gpGlobals->curtime)
+#endif // NEO
 		{
 			return false;	// allow watching until 3 seconds after death to see death animation
 		}

src/game/client/game_controls/SpectatorGUI.cpp

@@ -986,5 +986,50 @@ CON_COMMAND_F( spec_player, "Spectate player by partial name, steamid, or userid
 	}
 }
 
+#ifdef NEO 
+CON_COMMAND_F( spec_player_under_mouse, "Spectate player by partial name, steamid, or userid", FCVAR_CLIENTCMD_CAN_EXECUTE )
+{
+	C_NEO_Player *pNeoPlayer = C_NEO_Player::GetLocalNEOPlayer();
+	if ( !pNeoPlayer || !pNeoPlayer->IsObserver() )
+		return;
+
+	if (!engine->IsHLTV() || !HLTVCamera()->IsPVSLocked())
+	{
+		C_BaseEntity* currentTarget = pNeoPlayer->GetObserverTarget();
+		C_NEO_Player *target = nullptr;
+		float targetDotProduct = -1;
+		for (int i = 1; i < gpGlobals->maxClients; i++)
+		{
+			C_NEO_Player* pPlayer = ToNEOPlayer(UTIL_PlayerByIndex(i));
+			if (currentTarget != pPlayer && pNeoPlayer->IsValidObserverTarget(pPlayer) && pPlayer->IsAlive())
+			{
+				Vector vecForward;
+				AngleVectors( pNeoPlayer->EyeAngles(), &vecForward );
+
+				Vector vecToTarget = pPlayer->WorldSpaceCenter() - pNeoPlayer->EyePosition();
+				vecToTarget.NormalizeInPlace();
+				float dotProduct = DotProduct(vecForward, vecToTarget);
+				if (dotProduct > targetDotProduct && dotProduct > 0.5)
+				{
+					targetDotProduct = dotProduct;
+					target = pPlayer;
+				}
+			}
+		}
+
+		if (target)
+		{
+			if (engine->IsHLTV())
+			{
+				HLTVCamera()->SetPrimaryTarget(target->entindex());
+			}
+			else
+			{
+				engine->ClientCmd( VarArgs("spec_player_entity_number %d", target->entindex()) );
+			}
+		}
+	}
+}
+#endif // NEO