update counter before triggering latch #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #317 SUCCESS |
Member
|
Thank you! |
benjchristensen
added a commit
that referenced
this pull request
Oct 9, 2013
update counter before triggering latch
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
update counter before triggering latch
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned in #383
rx.concurrency.TestSchedulers.testSchedulingWithDueTime
is flaky because there is a race-condition where the test can assert the counter value before it is updated. fix is just to update the counter before releasing the latch.