[MIG] product_lot_sequence: Migration to 18.0

Author: Kimkhoi3010

product_lot_sequence/README.rst

@@ -131,6 +131,16 @@ Contributors
 
   - Frederic Grall
 
+- `Trobz <https://trobz.com>`__:
+
+  - Khoi (Kien Kim) <khoikk@trobz.com>
+
+Other credits
+-------------
+
+The migration of this module from 17.0 to 18.0 was financially supported
+by Camptocamp.
+
 Maintainers
 -----------
 

product_lot_sequence/__manifest__.py

@@ -5,7 +5,7 @@
     "name": "Product Lot Sequence",
     "summary": """
         Adds ability to define a lot sequence from the product""",
-    "version": "17.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "ForgeFlow S.L., Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/product-attribute",

product_lot_sequence/readme/CONTRIBUTORS.md

@@ -7,3 +7,5 @@
   - Yoshi Tashiro
 - [Apik](https://www.apik.cloud):
   - Frederic Grall
+- [Trobz](https://trobz.com):
+  - Khoi (Kien Kim) \<<khoikk@trobz.com>\>

product_lot_sequence/readme/CREDITS.md

@@ -0,0 +1 @@
+The migration of this module from 17.0 to 18.0 was financially supported by Camptocamp.

product_lot_sequence/static/description/index.html

@@ -386,7 +386,8 @@ <h1 class="title">Product Lot Sequence</h1>
 <li><a class="reference internal" href="#credits" id="toc-entry-7">Credits</a><ul>
 <li><a class="reference internal" href="#authors" id="toc-entry-8">Authors</a></li>
 <li><a class="reference internal" href="#contributors" id="toc-entry-9">Contributors</a></li>
-<li><a class="reference internal" href="#maintainers" id="toc-entry-10">Maintainers</a></li>
+<li><a class="reference internal" href="#other-credits" id="toc-entry-10">Other credits</a></li>
+<li><a class="reference internal" href="#maintainers" id="toc-entry-11">Maintainers</a></li>
 </ul>
 </li>
 </ul>
@@ -481,10 +482,19 @@ <h2><a class="toc-backref" href="#toc-entry-9">Contributors</a></h2>
 <li>Frederic Grall</li>
 </ul>
 </li>
+<li><a class="reference external" href="https://trobz.com">Trobz</a>:<ul>
+<li>Khoi (Kien Kim) &lt;<a class="reference external" href="mailto:khoikk&#64;trobz.com">khoikk&#64;trobz.com</a>&gt;</li>
 </ul>
+</li>
+</ul>
+</div>
+<div class="section" id="other-credits">
+<h2><a class="toc-backref" href="#toc-entry-10">Other credits</a></h2>
+<p>The migration of this module from 17.0 to 18.0 was financially supported
+by Camptocamp.</p>
 </div>
 <div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#toc-entry-10">Maintainers</a></h2>
+<h2><a class="toc-backref" href="#toc-entry-11">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org">
 <img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />

product_lot_sequence/tests/test_product_lot_sequence.py

@@ -93,13 +93,8 @@ def test_lot_onchange_product_id_global(self):
         self.assertFalse(product.lot_sequence_id)
         seq = self.env["ir.sequence"].search([("code", "=", "stock.lot.serial")])
         next_sequence_number = seq.get_next_char(seq.number_next_actual)
-        lot_form = Form(
-            self.stock_production_lot.with_context(
-                default_company_id=self.env.company.id
-            )
-        )
+        lot_form = Form(self.stock_production_lot)
         self.assertEqual(lot_form.name, next_sequence_number)
-        self.assertEqual(lot_form.company_id, self.env.company)
         lot_form.product_id = product
         lot = lot_form.save()
         self.assertEqual(lot.name, next_sequence_number)

product_lot_sequence/views/product_views.xml

@@ -6,7 +6,7 @@
         <field name="model">product.template</field>
         <field name="inherit_id" ref="stock.view_template_property_form" />
         <field name="arch" type="xml">
-            <field name="tracking" position="after">
+            <xpath expr="//field[@name='tracking']/ancestor::div[1]" position="after">
                 <field name="display_lot_sequence_fields" invisible="1" />
                 <field
                     name="lot_sequence_prefix"
@@ -25,7 +25,7 @@
                     name="lot_sequence_id"
                     invisible="tracking not in ['lot', 'serial'] or not display_lot_sequence_fields"
                 />
-            </field>
+            </xpath>
         </field>
     </record>
 </odoo>

product_lot_sequence/views/res_config_settings_views.xml

@@ -6,26 +6,15 @@
         <field name="inherit_id" ref="stock.res_config_settings_view_form" />
         <field name="arch" type="xml">
             <xpath expr="//block[@id='production_lot_info']" position="inside">
-                <div class="col-12 col-lg-6 o_setting_box">
-                    <label for="lot_sequence_padding" />
-                    <span
-                        class="fa fa-lg fa-building-o"
-                        title="Values set here are company-specific."
-                        aria-label="Values set here are company-specific."
-                        groups="base.group_multi_company"
-                    />
-                    <div class="text-muted">
-                        Default number of digits to be set on products for product lot/serial sequence generation.
-                    </div>
-                    <div class="content-group">
-                        <div class="mt16">
-                            <span><field
-                                name="lot_sequence_padding"
-                                class="oe_inline"
-                            /> digits</span>
-                        </div>
-                    </div>
-                </div>
+                <setting
+                    id="lot_sequence_padding_setting"
+                    company_dependent="1"
+                    groups="base.group_multi_company"
+                    help="Default number of digits to be set on products for product lot/serial sequence generation."
+                >
+                    <field name="lot_sequence_padding" class="oe_inline" />
+                    <span>digits</span>
+                </setting>
             </xpath>
         </field>
     </record>