[MIG] product_optional_product_quantity: Migration to 18.0

BhaveshHeliconia · BhaveshHeliconia · commit cdd265214bc3 · 2025-11-17T14:29:43.000+05:30
diff --git a/product_optional_product_quantity/README.rst b/product_optional_product_quantity/README.rst
@@ -17,13 +17,13 @@ Product Optional Product Quantity
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproduct--attribute-lightgray.png?logo=github
-    :target: https://github.com/OCA/product-attribute/tree/16.0/product_optional_product_quantity
+    :target: https://github.com/OCA/product-attribute/tree/18.0/product_optional_product_quantity
     :alt: OCA/product-attribute
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_optional_product_quantity
+    :target: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_optional_product_quantity
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/product-attribute&target_branch=16.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/product-attribute&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -69,7 +69,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/product-attribute/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/product-attribute/issues/new?body=module:%20product_optional_product_quantity%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/product-attribute/issues/new?body=module:%20product_optional_product_quantity%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -81,6 +81,13 @@ Authors
 
 * Cetmix
 
+Contributors
+------------
+
+- `Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>`__
+
+  - Bhavesh Heliconia
+
 Maintainers
 -----------
 
@@ -94,6 +101,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/product-attribute <https://github.com/OCA/product-attribute/tree/16.0/product_optional_product_quantity>`_ project on GitHub.
+This module is part of the `OCA/product-attribute <https://github.com/OCA/product-attribute/tree/18.0/product_optional_product_quantity>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
diff --git a/product_optional_product_quantity/__manifest__.py b/product_optional_product_quantity/__manifest__.py
@@ -2,14 +2,14 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 {
     "name": "Product Optional Product Quantity",
-    "version": "16.0.1.1.0",
+    "version": "18.0.1.0.0",
     "category": "Product",
     "summary": "Specify optional products quantity for product",
     "author": "Cetmix, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/product-attribute",
     "license": "AGPL-3",
     "depends": [
-        "sale_product_configurator",
+        "sale",
     ],
     "data": [
         "security/res_groups.xml",
diff --git a/product_optional_product_quantity/models/product_optional_line.py b/product_optional_product_quantity/models/product_optional_line.py
@@ -1,6 +1,6 @@
 # Copyright 2024 Cetmix OÜ
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 
 
 class ProductOptionalLine(models.Model):
@@ -39,7 +39,9 @@ def _check_same_product_as_related(self):
                 and r.product_tmpl_id == r.optional_product_tmpl_id
             ):
                 raise models.ValidationError(
-                    _("You can't add product this line is related to as optional.")
+                    self.env._(
+                        "You can't add product this line is related to as optional."
+                    )
                 )
 
     @api.constrains("product_tmpl_id", "optional_product_tmpl_id")
@@ -56,5 +58,5 @@ def _check_unique_products_within_product(self):
                 ]
             ):
                 raise models.ValidationError(
-                    _("You can't add two same products as optional.")
+                    self.env._("You can't add two same products as optional.")
                 )
diff --git a/product_optional_product_quantity/readme/CONTRIBUTORS.md b/product_optional_product_quantity/readme/CONTRIBUTORS.md
@@ -0,0 +1,2 @@
+- [Heliconia Solutions Pvt. Ltd.](https://www.heliconia.io)
+  - Bhavesh Heliconia
diff --git a/product_optional_product_quantity/static/description/index.html b/product_optional_product_quantity/static/description/index.html
@@ -8,10 +8,11 @@
 
 /*
 :Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
+:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
+Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -274,7 +275,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: grey; } /* line numbers */
+pre.code .ln { color: gray; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -300,7 +301,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic {
+span.problematic, pre.problematic {
   color: red }
 
 span.section-subtitle {
@@ -368,7 +369,7 @@ <h1 class="title">Product Optional Product Quantity</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:19c5748e08443684d61807c9a609fcd25cd03d10eb4a7420bd715a19eefb771f
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/product-attribute/tree/16.0/product_optional_product_quantity"><img alt="OCA/product-attribute" src="https://img.shields.io/badge/github-OCA%2Fproduct--attribute-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_optional_product_quantity"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/product-attribute&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/product-attribute/tree/18.0/product_optional_product_quantity"><img alt="OCA/product-attribute" src="https://img.shields.io/badge/github-OCA%2Fproduct--attribute-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_optional_product_quantity"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/product-attribute&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module implements core&nbsp;functionality for the optional product
 quantity multipliers. You can depend on this module to implement further
 user features.</p>
@@ -381,7 +382,8 @@ <h1 class="title">Product Optional Product Quantity</h1>
 <li><a class="reference internal" href="#bug-tracker" id="toc-entry-4">Bug Tracker</a></li>
 <li><a class="reference internal" href="#credits" id="toc-entry-5">Credits</a><ul>
 <li><a class="reference internal" href="#authors" id="toc-entry-6">Authors</a></li>
-<li><a class="reference internal" href="#maintainers" id="toc-entry-7">Maintainers</a></li>
+<li><a class="reference internal" href="#contributors" id="toc-entry-7">Contributors</a></li>
+<li><a class="reference internal" href="#maintainers" id="toc-entry-8">Maintainers</a></li>
 </ul>
 </li>
 </ul>
@@ -413,7 +415,7 @@ <h1><a class="toc-backref" href="#toc-entry-4">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/product-attribute/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/product-attribute/issues/new?body=module:%20product_optional_product_quantity%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/product-attribute/issues/new?body=module:%20product_optional_product_quantity%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -424,14 +426,25 @@ <h2><a class="toc-backref" href="#toc-entry-6">Authors</a></h2>
 <li>Cetmix</li>
 </ul>
 </div>
+<div class="section" id="contributors">
+<h2><a class="toc-backref" href="#toc-entry-7">Contributors</a></h2>
+<ul class="simple">
+<li><a class="reference external" href="https://www.heliconia.io">Heliconia Solutions Pvt. Ltd.</a><ul>
+<li>Bhavesh Heliconia</li>
+</ul>
+</li>
+</ul>
+</div>
 <div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
+<h2><a class="toc-backref" href="#toc-entry-8">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
+<a class="reference external image-reference" href="https://odoo-community.org">
+<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
+</a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/product-attribute/tree/16.0/product_optional_product_quantity">OCA/product-attribute</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/product-attribute/tree/18.0/product_optional_product_quantity">OCA/product-attribute</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
diff --git a/product_optional_product_quantity/tests/test_optional_product_quantity.py b/product_optional_product_quantity/tests/test_optional_product_quantity.py
@@ -1,32 +1,34 @@
 # Copyright 2024 Cetmix OÜ
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 from odoo import exceptions
-from odoo.tests.common import TransactionCase, tagged
+from odoo.tests.common import tagged
+
+from odoo.addons.base.tests.common import BaseCommon
 
 
 @tagged("post_install", "-at_install")
-class TestOptionalProductQuantity(TransactionCase):
+class TestOptionalProductQuantity(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
         cls.product_template_1 = cls.env["product.template"].create(
             {
                 "name": "Product 1",
-                "type": "product",
+                "type": "consu",
                 "categ_id": cls.env.ref("product.product_category_all").id,
             }
         )
         cls.product_template_2 = cls.env["product.template"].create(
             {
                 "name": "Product 2",
-                "type": "product",
+                "type": "consu",
                 "categ_id": cls.env.ref("product.product_category_all").id,
             }
         )
         cls.product_template_3 = cls.env["product.template"].create(
             {
                 "name": "Product 3",
-                "type": "product",
+                "type": "consu",
                 "categ_id": cls.env.ref("product.product_category_all").id,
             }
         )
diff --git a/product_optional_product_quantity/views/product_template_views.xml b/product_optional_product_quantity/views/product_template_views.xml
@@ -3,25 +3,22 @@
     <record id="product_template_view_form_inherit_optional_qty" model="ir.ui.view">
         <field name="name">product.template.view.form.inherit.optional.qty</field>
         <field name="model">product.template</field>
-        <field
-            name="inherit_id"
-            ref="sale_product_configurator.product_template_view_form"
-        />
+        <field name="inherit_id" ref="sale.product_template_view_form" />
         <field name="arch" type="xml">
             <field name="optional_product_ids" position="attributes">
                 <attribute name="invisible">1</attribute>
             </field>
             <field name="optional_product_ids" position="after">
                 <field name="product_optional_line_ids">
-                    <tree editable="top">
-                        <field name="company_id" invisible="1" />
-                        <field name="product_tmpl_id" invisible="1" />
+                    <list editable="top">
+                        <field name="company_id" column_invisible="True" />
+                        <field name="product_tmpl_id" column_invisible="True" />
                         <field name="optional_product_tmpl_id" />
                         <field
                             name="quantity"
                             groups="product_optional_product_quantity.group_product_optional_quantity"
                         />
-                    </tree>
+                    </list>
                 </field>
             </field>
         </field>
diff --git a/product_optional_product_quantity/views/res_config_settings_views.xml b/product_optional_product_quantity/views/res_config_settings_views.xml
@@ -5,22 +5,14 @@
         <field name="model">res.config.settings</field>
         <field name="inherit_id" ref="sale.res_config_settings_view_form" />
         <field name="arch" type="xml">
-            <div name="catalog_setting_container" position="inside">
-                <div
-                    class="col-12 col-lg-6 o_setting_box"
+            <xpath expr="//block[@name='catalog_setting_container']" position="inside">
+                <setting
                     id="optional_product_quantity_setting"
+                    help="Manage quantities of optional products"
                 >
-                    <div class="o_setting_left_pane">
-                        <field name="group_product_optional_quantity" />
-                    </div>
-                    <div class="o_setting_right_pane">
-                        <label for="group_product_optional_quantity" />
-                        <div class="text-muted">
-                            Manage quantities of optional products
-                        </div>
-                    </div>
-                </div>
-            </div>
+                    <field name="group_product_optional_quantity" />
+                </setting>
+            </xpath>
         </field>
     </record>
 </odoo>

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+- [Heliconia Solutions Pvt. Ltd.](https://www.heliconia.io)`
	`2`	`+ - Bhavesh Heliconia`
Original file line number	Diff line number	Diff line change
`@@ -1,32 +1,34 @@`
`1`	`1`	`# Copyright 2024 Cetmix OÜ`
`2`	`2`	`# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).`
`3`	`3`	`from odoo import exceptions`
`4`		`-from odoo.tests.common import TransactionCase, tagged`
	`4`	`+from odoo.tests.common import tagged`
	`5`	`+`
	`6`	`+from odoo.addons.base.tests.common import BaseCommon`
`5`	`7`
`6`	`8`
`7`	`9`	`@tagged("post_install", "-at_install")`
`8`		`-class TestOptionalProductQuantity(TransactionCase):`
	`10`	`+class TestOptionalProductQuantity(BaseCommon):`
`9`	`11`	`@classmethod`
`10`	`12`	`def setUpClass(cls):`
`11`	`13`	`super().setUpClass()`
`12`	`14`	`cls.product_template_1 = cls.env["product.template"].create(`
`13`	`15`	`{`
`14`	`16`	`"name": "Product 1",`
`15`		`- "type": "product",`
	`17`	`+ "type": "consu",`
`16`	`18`	`"categ_id": cls.env.ref("product.product_category_all").id,`
`17`	`19`	`}`
`18`	`20`	`)`
`19`	`21`	`cls.product_template_2 = cls.env["product.template"].create(`
`20`	`22`	`{`
`21`	`23`	`"name": "Product 2",`
`22`		`- "type": "product",`
	`24`	`+ "type": "consu",`
`23`	`25`	`"categ_id": cls.env.ref("product.product_category_all").id,`
`24`	`26`	`}`
`25`	`27`	`)`
`26`	`28`	`cls.product_template_3 = cls.env["product.template"].create(`
`27`	`29`	`{`
`28`	`30`	`"name": "Product 3",`
`29`		`- "type": "product",`
	`31`	`+ "type": "consu",`
`30`	`32`	`"categ_id": cls.env.ref("product.product_category_all").id,`
`31`	`33`	`}`
`32`	`34`	`)`