[Java][Spring] fix default response code#14399
Conversation
|
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) |
|
Wow - thank you! Just logged in to see how easy this would be to fix - and you've already done it :) |
| responses = { | ||
| {{#responses}} | ||
| @ApiResponse(responseCode = "{{{code}}}", description = "{{{message}}}"{{#baseType}}, content = { | ||
| @ApiResponse(responseCode = {{#isDefault}}"default"{{/isDefault}}{{^isDefault}}"{{{code}}}"{{/isDefault}}, description = "{{{message}}}"{{#baseType}}, content = { |
There was a problem hiding this comment.
Code change looks great! Should there be a unit test for this? I'm also happy to add it if you think it adds value
There was a problem hiding this comment.
well, samples are updated. do you think we still need unit test for this? If yes I can add them quickly
There was a problem hiding this comment.
Sorry missed this. I do think unit tests still add value because if someone breaks it, the unit tests will block the submission (hopefully) or alert them that the samples were updated incorrectly. I can add these in a few days and send out for review
|
@wing328 could you please review? |
4 participants
fix for #14394
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)