From 4050994e3053a0054fb3328cadef19807a431051 Mon Sep 17 00:00:00 2001
From: Tomas Bjerre <tomas.bjerre85@gmail.com>
Date: Sun, 19 Jan 2020 09:19:23 +0100
Subject: [PATCH 1/2] Spotbugs, PMD and Checkstyle #33

---
 modules/openapi-generator-cli/pom.xml         | 27 ++++++
 modules/openapi-generator-core/pom.xml        | 32 ++++++
 .../openapi-generator-gradle-plugin/pom.xml   | 25 +++++
 .../openapi-generator-maven-plugin/pom.xml    | 27 ++++++
 modules/openapi-generator-online/pom.xml      | 27 ++++++
 modules/openapi-generator/pom.xml             | 27 ++++++
 pom.xml                                       | 97 +++++++++++++++++++
 spotbugs-exclude.xml                          | 25 +++++
 8 files changed, 287 insertions(+)
 create mode 100644 spotbugs-exclude.xml

diff --git a/modules/openapi-generator-cli/pom.xml b/modules/openapi-generator-cli/pom.xml
index 6aa9eb42defc..027ea7e76ab2 100644
--- a/modules/openapi-generator-cli/pom.xml
+++ b/modules/openapi-generator-cli/pom.xml
@@ -26,6 +26,33 @@
             </resource>
         </resources>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <configuration>
+                    <configLocation>${project.basedir}/../../google_checkstyle.xml</configLocation>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>com.github.spotbugs</groupId>
+                <artifactId>spotbugs-maven-plugin</artifactId>
+                <configuration>
+                    <excludeFilterFile>${project.basedir}/../../spotbugs-exclude.xml</excludeFilterFile>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-pmd-plugin</artifactId>
+            </plugin>
+            <plugin>
+                <groupId>se.bjurr.violations</groupId>
+                <artifactId>violations-maven-plugin</artifactId>
+                <configuration>
+                    <!-- Should be decreased continuousle as issues are fixed, and will eventually 
+                        reach 0. -->
+                    <maxViolations>274</maxViolations>
+                </configuration>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
diff --git a/modules/openapi-generator-core/pom.xml b/modules/openapi-generator-core/pom.xml
index 58e2f5714d2d..d8585d7e60b7 100644
--- a/modules/openapi-generator-core/pom.xml
+++ b/modules/openapi-generator-core/pom.xml
@@ -16,6 +16,38 @@
   <name>openapi-generator-core</name>
   <url>https://github.com/openapitools/openapi-generator</url>
 
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-checkstyle-plugin</artifactId>
+        <configuration>
+          <configLocation>${project.basedir}/../../google_checkstyle.xml</configLocation>
+        </configuration>
+      </plugin>
+      <plugin>
+        <groupId>com.github.spotbugs</groupId>
+        <artifactId>spotbugs-maven-plugin</artifactId>
+        <configuration>
+          <excludeFilterFile>${project.basedir}/../../spotbugs-exclude.xml</excludeFilterFile>
+        </configuration>
+      </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-pmd-plugin</artifactId>
+      </plugin>
+      <plugin>
+        <groupId>se.bjurr.violations</groupId>
+        <artifactId>violations-maven-plugin</artifactId>
+        <configuration>
+          <!-- Should be decreased continuousle as issues are fixed, and will eventually
+            reach 0. -->
+          <maxViolations>571</maxViolations>
+        </configuration>
+      </plugin>
+    </plugins>
+  </build>
+
   <dependencies>
     <dependency>
       <groupId>com.google.guava</groupId>
diff --git a/modules/openapi-generator-gradle-plugin/pom.xml b/modules/openapi-generator-gradle-plugin/pom.xml
index 3508398624dd..2cc5325f12c8 100644
--- a/modules/openapi-generator-gradle-plugin/pom.xml
+++ b/modules/openapi-generator-gradle-plugin/pom.xml
@@ -65,6 +65,31 @@
         </pluginManagement>
 
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <configuration>
+                    <configLocation>${project.basedir}/../../google_checkstyle.xml</configLocation>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>com.github.spotbugs</groupId>
+                <artifactId>spotbugs-maven-plugin</artifactId>
+                <configuration>
+                    <excludeFilterFile>${project.basedir}/../../spotbugs-exclude.xml</excludeFilterFile>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-pmd-plugin</artifactId>
+            </plugin>
+            <plugin>
+                <groupId>se.bjurr.violations</groupId>
+                <artifactId>violations-maven-plugin</artifactId>
+                <configuration>
+                    <maxViolations>0</maxViolations>
+                </configuration>
+            </plugin>
             <!-- 2) run gradle -->
             <plugin>
                 <groupId>org.fortasoft</groupId>
diff --git a/modules/openapi-generator-maven-plugin/pom.xml b/modules/openapi-generator-maven-plugin/pom.xml
index d74b8ff56243..af0233f1e9a7 100644
--- a/modules/openapi-generator-maven-plugin/pom.xml
+++ b/modules/openapi-generator-maven-plugin/pom.xml
@@ -89,6 +89,33 @@
             </plugins>
         </pluginManagement>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <configuration>
+                    <configLocation>${project.basedir}/../../google_checkstyle.xml</configLocation>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>com.github.spotbugs</groupId>
+                <artifactId>spotbugs-maven-plugin</artifactId>
+                <configuration>
+                    <excludeFilterFile>${project.basedir}/../../spotbugs-exclude.xml</excludeFilterFile>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-pmd-plugin</artifactId>
+            </plugin>
+            <plugin>
+                <groupId>se.bjurr.violations</groupId>
+                <artifactId>violations-maven-plugin</artifactId>
+                <configuration>
+                    <!-- Should be decreased continuousle as issues are fixed, and will eventually 
+                        reach 0. -->
+                    <maxViolations>329</maxViolations>
+                </configuration>
+            </plugin>
             <plugin>
                 <groupId>net.revelc.code</groupId>
                 <artifactId>formatter-maven-plugin</artifactId>
diff --git a/modules/openapi-generator-online/pom.xml b/modules/openapi-generator-online/pom.xml
index 1d50a9c70f49..8fa09cedc466 100644
--- a/modules/openapi-generator-online/pom.xml
+++ b/modules/openapi-generator-online/pom.xml
@@ -42,6 +42,33 @@
             </resource>
         </resources>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <configuration>
+                    <configLocation>${project.basedir}/../../google_checkstyle.xml</configLocation>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>com.github.spotbugs</groupId>
+                <artifactId>spotbugs-maven-plugin</artifactId>
+                <configuration>
+                    <excludeFilterFile>${project.basedir}/../../spotbugs-exclude.xml</excludeFilterFile>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-pmd-plugin</artifactId>
+            </plugin>
+            <plugin>
+                <groupId>se.bjurr.violations</groupId>
+                <artifactId>violations-maven-plugin</artifactId>
+                <configuration>
+                    <!-- Should be decreased continuousle as issues are fixed, and will eventually 
+                        reach 0. -->
+                    <maxViolations>153</maxViolations>
+                </configuration>
+            </plugin>
             <plugin>
                 <groupId>org.springframework.boot</groupId>
                 <artifactId>spring-boot-maven-plugin</artifactId>
diff --git a/modules/openapi-generator/pom.xml b/modules/openapi-generator/pom.xml
index 69f0314bb62a..d44bf58b0b87 100644
--- a/modules/openapi-generator/pom.xml
+++ b/modules/openapi-generator/pom.xml
@@ -43,6 +43,33 @@
         <directory>target</directory>
         <finalName>${project.artifactId}-${project.version}</finalName>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <configuration>
+                    <configLocation>${project.basedir}/../../google_checkstyle.xml</configLocation>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>com.github.spotbugs</groupId>
+                <artifactId>spotbugs-maven-plugin</artifactId>
+                <configuration>
+                    <excludeFilterFile>${project.basedir}/../../spotbugs-exclude.xml</excludeFilterFile>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-pmd-plugin</artifactId>
+            </plugin>
+            <plugin>
+                <groupId>se.bjurr.violations</groupId>
+                <artifactId>violations-maven-plugin</artifactId>
+                <configuration>
+                    <!-- Should be decreased continuousle as issues are fixed, and will eventually 
+                        reach 0. -->
+                    <maxViolations>12089</maxViolations>
+                </configuration>
+            </plugin>
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>exec-maven-plugin</artifactId>
diff --git a/pom.xml b/pom.xml
index 2bfd23742cf7..8f941ad5a48c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -100,6 +100,66 @@
         <directory>target</directory>
         <finalName>${project.artifactId}-${project.version}</finalName>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>3.1.0</version>
+                <configuration>
+                    <consoleOutput>false</consoleOutput>
+                    <failsOnError>false</failsOnError>
+                </configuration>
+                <executions>
+                    <execution>
+                        <id>checkstyle-check</id>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                        <phase>verify</phase>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
+                <groupId>com.github.spotbugs</groupId>
+                <artifactId>spotbugs-maven-plugin</artifactId>
+                <version>3.1.12.2</version>
+                <configuration>
+                    <failOnError>false</failOnError>
+                    <effort>max</effort>
+                    <excludes>
+                        <exclude>**/generated/*.java</exclude>
+                    </excludes>
+                </configuration>
+                <executions>
+                    <execution>
+                        <id>spotbugs-check</id>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                        <phase>verify</phase>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-pmd-plugin</artifactId>
+                <version>3.12.0</version>
+                <configuration>
+                    <failOnViolation>false</failOnViolation>
+                    <printFailingErrors>false</printFailingErrors>
+                    <rulesets>
+                        <ruleset>category/java/errorprone.xml</ruleset>
+                    </rulesets>
+                </configuration>
+                <executions>
+                    <execution>
+                        <id>pmd-check</id>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                        <phase>verify</phase>
+                    </execution>
+                </executions>
+            </plugin>
             <plugin>
                 <groupId>net.revelc.code</groupId>
                 <artifactId>formatter-maven-plugin</artifactId>
@@ -360,6 +420,43 @@
         </plugins>
         <pluginManagement>
             <plugins>
+                <plugin>
+                    <groupId>se.bjurr.violations</groupId>
+                    <artifactId>violations-maven-plugin</artifactId>
+                    <version>1.33</version>
+                    <configuration>
+                        <maxViolations>0</maxViolations>
+                        <detailLevel>VERBOSE</detailLevel>
+                        <violations>
+                            <violation>
+                                <parser>FINDBUGS</parser>
+                                <reporter>Spotbugs</reporter>
+                                <folder>${project.basedir}</folder>
+                                <pattern>.*/spotbugsXml\.xml$</pattern>
+                            </violation>
+                            <violation>
+                                <parser>PMD</parser>
+                                <reporter>PMD</reporter>
+                                <folder>${project.basedir}</folder>
+                                <pattern>.*/pmd\.xml$</pattern>
+                            </violation>
+                            <violation>
+                                <parser>CHECKSTYLE</parser>
+                                <reporter>Checkstyle</reporter>
+                                <folder>${project.basedir}</folder>
+                                <pattern>.*/checkstyle-result\.xml$</pattern>
+                            </violation>
+                        </violations>
+                    </configuration>
+                    <executions>
+                        <execution>
+                            <phase>verify</phase>
+                            <goals>
+                                <goal>violations</goal>
+                            </goals>
+                        </execution>
+                    </executions>
+                </plugin>
                 <plugin>
                     <groupId>net.revelc.code</groupId>
                     <artifactId>formatter-maven-plugin</artifactId>
diff --git a/spotbugs-exclude.xml b/spotbugs-exclude.xml
new file mode 100644
index 000000000000..562eca9ee223
--- /dev/null
+++ b/spotbugs-exclude.xml
@@ -0,0 +1,25 @@
+<FindBugsFilter>
+
+	<Match>
+		<Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" />
+	</Match>
+
+	<Match>
+		<Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" />
+	</Match>
+
+	<Match>
+		<Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
+	</Match>
+
+	<Match>
+		<Bug pattern="URF_UNREAD_FIELD" />
+		<Or>
+			<And>
+				<Class name="io.undertow.server.protocol.ajp.AjpRequestParseState" />
+				<Field name="dataSize" />
+			</And>
+		</Or>
+	</Match>
+
+</FindBugsFilter>
\ No newline at end of file

From b7c33ec0156a4a6596846fdd54f0cddd3bfe0fee Mon Sep 17 00:00:00 2001
From: Tomas Bjerre <tomas.bjerre85@gmail.com>
Date: Sun, 19 Jan 2020 16:07:20 +0100
Subject: [PATCH 2/2] Reducing Spotbugs effort to min #33

 * Also using project.parent.basedir and avoiding relative paths in pom files.
 * Filtering out samples.
---
 .gitignore                                      |  2 ++
 modules/openapi-generator-cli/pom.xml           |  9 ++-------
 modules/openapi-generator-core/pom.xml          |  9 ++-------
 modules/openapi-generator-gradle-plugin/pom.xml |  7 ++-----
 modules/openapi-generator-maven-plugin/pom.xml  |  9 ++-------
 modules/openapi-generator-online/pom.xml        |  6 +++---
 modules/openapi-generator/pom.xml               |  6 +++---
 pom.xml                                         | 14 +++++++++-----
 8 files changed, 25 insertions(+), 37 deletions(-)

diff --git a/.gitignore b/.gitignore
index 81c33b22aac5..36dfef78c283 100644
--- a/.gitignore
+++ b/.gitignore
@@ -29,6 +29,8 @@ packages/
 .vagrant/
 .vscode/
 **/.vs
+bin
+.factorypath
 
 .settings
 
diff --git a/modules/openapi-generator-cli/pom.xml b/modules/openapi-generator-cli/pom.xml
index 027ea7e76ab2..0120e7149be9 100644
--- a/modules/openapi-generator-cli/pom.xml
+++ b/modules/openapi-generator-cli/pom.xml
@@ -30,14 +30,14 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
                 <configuration>
-                    <configLocation>${project.basedir}/../../google_checkstyle.xml</configLocation>
+                    <configLocation>${project.parent.basedir}${file.separator}google_checkstyle.xml</configLocation>
                 </configuration>
             </plugin>
             <plugin>
                 <groupId>com.github.spotbugs</groupId>
                 <artifactId>spotbugs-maven-plugin</artifactId>
                 <configuration>
-                    <excludeFilterFile>${project.basedir}/../../spotbugs-exclude.xml</excludeFilterFile>
+                    <excludeFilterFile>${project.parent.basedir}${file.separator}spotbugs-exclude.xml</excludeFilterFile>
                 </configuration>
             </plugin>
             <plugin>
@@ -47,11 +47,6 @@
             <plugin>
                 <groupId>se.bjurr.violations</groupId>
                 <artifactId>violations-maven-plugin</artifactId>
-                <configuration>
-                    <!-- Should be decreased continuousle as issues are fixed, and will eventually 
-                        reach 0. -->
-                    <maxViolations>274</maxViolations>
-                </configuration>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
diff --git a/modules/openapi-generator-core/pom.xml b/modules/openapi-generator-core/pom.xml
index d8585d7e60b7..fafeb1bb25cc 100644
--- a/modules/openapi-generator-core/pom.xml
+++ b/modules/openapi-generator-core/pom.xml
@@ -22,14 +22,14 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
         <configuration>
-          <configLocation>${project.basedir}/../../google_checkstyle.xml</configLocation>
+          <configLocation>${project.parent.basedir}${file.separator}google_checkstyle.xml</configLocation>
         </configuration>
       </plugin>
       <plugin>
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
         <configuration>
-          <excludeFilterFile>${project.basedir}/../../spotbugs-exclude.xml</excludeFilterFile>
+          <excludeFilterFile>${project.parent.basedir}${file.separator}spotbugs-exclude.xml</excludeFilterFile>
         </configuration>
       </plugin>
       <plugin>
@@ -39,11 +39,6 @@
       <plugin>
         <groupId>se.bjurr.violations</groupId>
         <artifactId>violations-maven-plugin</artifactId>
-        <configuration>
-          <!-- Should be decreased continuousle as issues are fixed, and will eventually
-            reach 0. -->
-          <maxViolations>571</maxViolations>
-        </configuration>
       </plugin>
     </plugins>
   </build>
diff --git a/modules/openapi-generator-gradle-plugin/pom.xml b/modules/openapi-generator-gradle-plugin/pom.xml
index 2cc5325f12c8..2d53bc49a5c8 100644
--- a/modules/openapi-generator-gradle-plugin/pom.xml
+++ b/modules/openapi-generator-gradle-plugin/pom.xml
@@ -69,14 +69,14 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
                 <configuration>
-                    <configLocation>${project.basedir}/../../google_checkstyle.xml</configLocation>
+                    <configLocation>${project.parent.basedir}${file.separator}google_checkstyle.xml</configLocation>
                 </configuration>
             </plugin>
             <plugin>
                 <groupId>com.github.spotbugs</groupId>
                 <artifactId>spotbugs-maven-plugin</artifactId>
                 <configuration>
-                    <excludeFilterFile>${project.basedir}/../../spotbugs-exclude.xml</excludeFilterFile>
+                    <excludeFilterFile>${project.parent.basedir}${file.separator}spotbugs-exclude.xml</excludeFilterFile>
                 </configuration>
             </plugin>
             <plugin>
@@ -86,9 +86,6 @@
             <plugin>
                 <groupId>se.bjurr.violations</groupId>
                 <artifactId>violations-maven-plugin</artifactId>
-                <configuration>
-                    <maxViolations>0</maxViolations>
-                </configuration>
             </plugin>
             <!-- 2) run gradle -->
             <plugin>
diff --git a/modules/openapi-generator-maven-plugin/pom.xml b/modules/openapi-generator-maven-plugin/pom.xml
index af0233f1e9a7..5002686f5b9a 100644
--- a/modules/openapi-generator-maven-plugin/pom.xml
+++ b/modules/openapi-generator-maven-plugin/pom.xml
@@ -93,14 +93,14 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
                 <configuration>
-                    <configLocation>${project.basedir}/../../google_checkstyle.xml</configLocation>
+                    <configLocation>${project.parent.basedir}${file.separator}google_checkstyle.xml</configLocation>
                 </configuration>
             </plugin>
             <plugin>
                 <groupId>com.github.spotbugs</groupId>
                 <artifactId>spotbugs-maven-plugin</artifactId>
                 <configuration>
-                    <excludeFilterFile>${project.basedir}/../../spotbugs-exclude.xml</excludeFilterFile>
+                    <excludeFilterFile>${project.parent.basedir}${file.separator}spotbugs-exclude.xml</excludeFilterFile>
                 </configuration>
             </plugin>
             <plugin>
@@ -110,11 +110,6 @@
             <plugin>
                 <groupId>se.bjurr.violations</groupId>
                 <artifactId>violations-maven-plugin</artifactId>
-                <configuration>
-                    <!-- Should be decreased continuousle as issues are fixed, and will eventually 
-                        reach 0. -->
-                    <maxViolations>329</maxViolations>
-                </configuration>
             </plugin>
             <plugin>
                 <groupId>net.revelc.code</groupId>
diff --git a/modules/openapi-generator-online/pom.xml b/modules/openapi-generator-online/pom.xml
index 8fa09cedc466..7a798a6c0352 100644
--- a/modules/openapi-generator-online/pom.xml
+++ b/modules/openapi-generator-online/pom.xml
@@ -46,14 +46,14 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
                 <configuration>
-                    <configLocation>${project.basedir}/../../google_checkstyle.xml</configLocation>
+                    <configLocation>${project.parent.basedir}${file.separator}google_checkstyle.xml</configLocation>
                 </configuration>
             </plugin>
             <plugin>
                 <groupId>com.github.spotbugs</groupId>
                 <artifactId>spotbugs-maven-plugin</artifactId>
                 <configuration>
-                    <excludeFilterFile>${project.basedir}/../../spotbugs-exclude.xml</excludeFilterFile>
+                    <excludeFilterFile>${project.parent.basedir}${file.separator}spotbugs-exclude.xml</excludeFilterFile>
                 </configuration>
             </plugin>
             <plugin>
@@ -66,7 +66,7 @@
                 <configuration>
                     <!-- Should be decreased continuousle as issues are fixed, and will eventually 
                         reach 0. -->
-                    <maxViolations>153</maxViolations>
+                    <maxViolations>3</maxViolations>
                 </configuration>
             </plugin>
             <plugin>
diff --git a/modules/openapi-generator/pom.xml b/modules/openapi-generator/pom.xml
index d44bf58b0b87..5a741c42cf1d 100644
--- a/modules/openapi-generator/pom.xml
+++ b/modules/openapi-generator/pom.xml
@@ -47,14 +47,14 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
                 <configuration>
-                    <configLocation>${project.basedir}/../../google_checkstyle.xml</configLocation>
+                    <configLocation>${project.parent.basedir}${file.separator}google_checkstyle.xml</configLocation>
                 </configuration>
             </plugin>
             <plugin>
                 <groupId>com.github.spotbugs</groupId>
                 <artifactId>spotbugs-maven-plugin</artifactId>
                 <configuration>
-                    <excludeFilterFile>${project.basedir}/../../spotbugs-exclude.xml</excludeFilterFile>
+                    <excludeFilterFile>${project.parent.basedir}${file.separator}spotbugs-exclude.xml</excludeFilterFile>
                 </configuration>
             </plugin>
             <plugin>
@@ -67,7 +67,7 @@
                 <configuration>
                     <!-- Should be decreased continuousle as issues are fixed, and will eventually 
                         reach 0. -->
-                    <maxViolations>12089</maxViolations>
+                    <maxViolations>65</maxViolations>
                 </configuration>
             </plugin>
             <plugin>
diff --git a/pom.xml b/pom.xml
index 8f941ad5a48c..1e79f7b84f74 100644
--- a/pom.xml
+++ b/pom.xml
@@ -107,6 +107,7 @@
                 <configuration>
                     <consoleOutput>false</consoleOutput>
                     <failsOnError>false</failsOnError>
+                    <excludes>**/samples/*.java</excludes>
                 </configuration>
                 <executions>
                     <execution>
@@ -124,10 +125,9 @@
                 <version>3.1.12.2</version>
                 <configuration>
                     <failOnError>false</failOnError>
-                    <effort>max</effort>
-                    <excludes>
-                        <exclude>**/generated/*.java</exclude>
-                    </excludes>
+                    <!-- https://spotbugs.readthedocs.io/en/stable/effort.html -->
+                    <effort>min</effort>
+                    <excludes>**/samples/*.java</excludes>
                 </configuration>
                 <executions>
                     <execution>
@@ -149,6 +149,9 @@
                     <rulesets>
                         <ruleset>category/java/errorprone.xml</ruleset>
                     </rulesets>
+                    <excludes>
+                    	<exclude>**/samples/*.java</exclude>
+                    </excludes>
                 </configuration>
                 <executions>
                     <execution>
@@ -423,10 +426,11 @@
                 <plugin>
                     <groupId>se.bjurr.violations</groupId>
                     <artifactId>violations-maven-plugin</artifactId>
-                    <version>1.33</version>
+                    <version>1.34</version>
                     <configuration>
                         <maxViolations>0</maxViolations>
                         <detailLevel>VERBOSE</detailLevel>
+                        <minSeverity>ERROR</minSeverity>
                         <violations>
                             <violation>
                                 <parser>FINDBUGS</parser>