Skip to content

Commit 437cb3d

Browse files
KAGA-KOKOPeter Zijlstra
authored andcommitted
cpumask: Introduce cpumask_weighted_or()
CID management OR's two cpumasks and then calculates the weight on the result. That's inefficient as that has to walk the same stuff twice. As this is done with runqueue lock held, there is a real benefit of speeding this up. Depending on the system this results in 10-20% less cycles spent with runqueue lock held for a 4K cpumask. Provide cpumask_weighted_or() and the corresponding bitmap functions which return the weight of the OR result right away. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Yury Norov (NVIDIA) <yury.norov@gmail.com> Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Link: https://patch.msgid.link/20251119172549.448263340@linutronix.de
1 parent 0d032a4 commit 437cb3d

File tree

3 files changed

+37
-0
lines changed

3 files changed

+37
-0
lines changed

include/linux/bitmap.h

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ struct device;
4545
* bitmap_copy(dst, src, nbits) *dst = *src
4646
* bitmap_and(dst, src1, src2, nbits) *dst = *src1 & *src2
4747
* bitmap_or(dst, src1, src2, nbits) *dst = *src1 | *src2
48+
* bitmap_weighted_or(dst, src1, src2, nbits) *dst = *src1 | *src2. Returns Hamming Weight of dst
4849
* bitmap_xor(dst, src1, src2, nbits) *dst = *src1 ^ *src2
4950
* bitmap_andnot(dst, src1, src2, nbits) *dst = *src1 & ~(*src2)
5051
* bitmap_complement(dst, src, nbits) *dst = ~(*src)
@@ -165,6 +166,8 @@ bool __bitmap_and(unsigned long *dst, const unsigned long *bitmap1,
165166
const unsigned long *bitmap2, unsigned int nbits);
166167
void __bitmap_or(unsigned long *dst, const unsigned long *bitmap1,
167168
const unsigned long *bitmap2, unsigned int nbits);
169+
unsigned int __bitmap_weighted_or(unsigned long *dst, const unsigned long *bitmap1,
170+
const unsigned long *bitmap2, unsigned int nbits);
168171
void __bitmap_xor(unsigned long *dst, const unsigned long *bitmap1,
169172
const unsigned long *bitmap2, unsigned int nbits);
170173
bool __bitmap_andnot(unsigned long *dst, const unsigned long *bitmap1,
@@ -337,6 +340,18 @@ void bitmap_or(unsigned long *dst, const unsigned long *src1,
337340
__bitmap_or(dst, src1, src2, nbits);
338341
}
339342

343+
static __always_inline
344+
unsigned int bitmap_weighted_or(unsigned long *dst, const unsigned long *src1,
345+
const unsigned long *src2, unsigned int nbits)
346+
{
347+
if (small_const_nbits(nbits)) {
348+
*dst = *src1 | *src2;
349+
return hweight_long(*dst & BITMAP_LAST_WORD_MASK(nbits));
350+
} else {
351+
return __bitmap_weighted_or(dst, src1, src2, nbits);
352+
}
353+
}
354+
340355
static __always_inline
341356
void bitmap_xor(unsigned long *dst, const unsigned long *src1,
342357
const unsigned long *src2, unsigned int nbits)

include/linux/cpumask.h

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -728,6 +728,22 @@ void cpumask_or(struct cpumask *dstp, const struct cpumask *src1p,
728728
cpumask_bits(src2p), small_cpumask_bits);
729729
}
730730

731+
/**
732+
* cpumask_weighted_or - *dstp = *src1p | *src2p and return the weight of the result
733+
* @dstp: the cpumask result
734+
* @src1p: the first input
735+
* @src2p: the second input
736+
*
737+
* Return: The number of bits set in the resulting cpumask @dstp
738+
*/
739+
static __always_inline
740+
unsigned int cpumask_weighted_or(struct cpumask *dstp, const struct cpumask *src1p,
741+
const struct cpumask *src2p)
742+
{
743+
return bitmap_weighted_or(cpumask_bits(dstp), cpumask_bits(src1p),
744+
cpumask_bits(src2p), small_cpumask_bits);
745+
}
746+
731747
/**
732748
* cpumask_xor - *dstp = *src1p ^ *src2p
733749
* @dstp: the cpumask result

lib/bitmap.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -355,6 +355,12 @@ unsigned int __bitmap_weight_andnot(const unsigned long *bitmap1,
355355
}
356356
EXPORT_SYMBOL(__bitmap_weight_andnot);
357357

358+
unsigned int __bitmap_weighted_or(unsigned long *dst, const unsigned long *bitmap1,
359+
const unsigned long *bitmap2, unsigned int bits)
360+
{
361+
return BITMAP_WEIGHT(({dst[idx] = bitmap1[idx] | bitmap2[idx]; dst[idx]; }), bits);
362+
}
363+
358364
void __bitmap_set(unsigned long *map, unsigned int start, int len)
359365
{
360366
unsigned long *p = map + BIT_WORD(start);

0 commit comments

Comments
 (0)