Skip to content

Commit 7ffc923

Browse files
surenbaghdasaryanakpm00
authored andcommitted
alloc_tag: avoid warnings when freeing non-compound "tail" pages
When freeing "tail" pages of a non-compount high-order page, we properly subtract the allocation tag counters, however later when these pages are released, alloc_tag_sub() will issue warnings because tags for these pages are NULL. This issue was originally anticipated by Vlastimil in his review [1] and then recently reported by David. Prevent warnings by marking the tags empty. Link: https://lkml.kernel.org/r/20250915212756.3998938-4-surenb@google.com Link: https://lore.kernel.org/all/6db0f0c8-81cb-4d04-9560-ba73d63db4b8@suse.cz/ [1] Signed-off-by: Suren Baghdasaryan <surenb@google.com> Suggested-by: David Wang <00107082@163.com> Acked-by: Shakeel Butt <shakeel.butt@linux.dev> Acked-by: Usama Arif <usamaarif642@gmail.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Kent Overstreet <kent.overstreet@linux.dev> Cc: Pasha Tatashin <pasha.tatashin@soleen.com> Cc: Sourav Panda <souravpanda@google.com> Cc: Vlastimil Babka <vbabka@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 9e8a0bb commit 7ffc923

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

mm/page_alloc.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5240,9 +5240,16 @@ static void ___free_pages(struct page *page, unsigned int order,
52405240
__free_frozen_pages(page, order, fpi_flags);
52415241
else if (!head) {
52425242
pgalloc_tag_sub_pages(tag, (1 << order) - 1);
5243-
while (order-- > 0)
5243+
while (order-- > 0) {
5244+
/*
5245+
* The "tail" pages of this non-compound high-order
5246+
* page will have no code tags, so to avoid warnings
5247+
* mark them as empty.
5248+
*/
5249+
clear_page_tag_ref(page + (1 << order));
52445250
__free_frozen_pages(page + (1 << order), order,
52455251
fpi_flags);
5252+
}
52465253
}
52475254
}
52485255

0 commit comments

Comments
 (0)