Skip to content

Commit 8d00526

Browse files
ebiedermkees
authored andcommitted
binfmt_flat: Drop vestiges of coredump support
There is the briefest start of coredump support in binfmt_flat. It is actually a pain to maintain as binfmt_flat is not built on most architectures so it is easy to overlook. Since the support does not do anything remove it. Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com> Acked-by: Greg Ungerer <gerg@linux-m68k.org> Signed-off-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/87mtgh17li.fsf_-_@email.froward.int.ebiederm.org
1 parent 6045ab5 commit 8d00526

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

fs/binfmt_flat.c

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
#include <linux/flat.h>
3838
#include <linux/uaccess.h>
3939
#include <linux/vmalloc.h>
40-
#include <linux/coredump.h>
4140

4241
#include <asm/byteorder.h>
4342
#include <asm/unaligned.h>
@@ -98,33 +97,12 @@ static int load_flat_shared_library(int id, struct lib_info *p);
9897
#endif
9998

10099
static int load_flat_binary(struct linux_binprm *);
101-
#ifdef CONFIG_COREDUMP
102-
static int flat_core_dump(struct coredump_params *cprm);
103-
#endif
104100

105101
static struct linux_binfmt flat_format = {
106102
.module = THIS_MODULE,
107103
.load_binary = load_flat_binary,
108-
#ifdef CONFIG_COREDUMP
109-
.core_dump = flat_core_dump,
110-
.min_coredump = PAGE_SIZE
111-
#endif
112104
};
113105

114-
/****************************************************************************/
115-
/*
116-
* Routine writes a core dump image in the current directory.
117-
* Currently only a stub-function.
118-
*/
119-
120-
#ifdef CONFIG_COREDUMP
121-
static int flat_core_dump(struct coredump_params *cprm)
122-
{
123-
pr_warn("Process %s:%d received signr %d and should have core dumped\n",
124-
current->comm, current->pid, cprm->siginfo->si_signo);
125-
return 1;
126-
}
127-
#endif
128106

129107
/****************************************************************************/
130108
/*

0 commit comments

Comments
 (0)