Skip to content

Commit a6b9f5b

Browse files
leitaobrauner
authored andcommitted
fs/namei: Remove redundant DCACHE_MANAGED_DENTRY check in __follow_mount_rcu
The check for DCACHE_MANAGED_DENTRY at the start of __follow_mount_rcu() is redundant because the only caller (handle_mounts) already verifies d_managed(dentry) before calling this function, so, dentry in __follow_mount_rcu() has always DCACHE_MANAGED_DENTRY set. This early-out optimization never fires in practice - but it is marking as likely(). This was detected with branch profiling, which shows 100% misprediction in this likely. Remove the whole if clause instead of removing the likely, given we know for sure that dentry is not DCACHE_MANAGED_DENTRY. Signed-off-by: Breno Leitao <leitao@debian.org> Link: https://patch.msgid.link/20260105-dcache-v1-1-f0d904b4a7c2@debian.org Acked-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 729d015 commit a6b9f5b

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

fs/namei.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1624,9 +1624,6 @@ static bool __follow_mount_rcu(struct nameidata *nd, struct path *path)
16241624
struct dentry *dentry = path->dentry;
16251625
unsigned int flags = dentry->d_flags;
16261626

1627-
if (likely(!(flags & DCACHE_MANAGED_DENTRY)))
1628-
return true;
1629-
16301627
if (unlikely(nd->flags & LOOKUP_NO_XDEV))
16311628
return false;
16321629

0 commit comments

Comments
 (0)