Skip to content

Commit e6eff39

Browse files
jankaratytso
authored andcommitted
jbd2: remove wrong sb->s_sequence check
Journal emptiness is not determined by sb->s_sequence == 0 but rather by sb->s_start == 0 (which is set a few lines above). Furthermore 0 is a valid transaction ID so the check can spuriously trigger. Remove the invalid WARN_ON. CC: stable@vger.kernel.org Signed-off-by: Jan Kara <jack@suse.cz> Reviewed-by: Zhang Yi <yi.zhang@huawei.com> Link: https://patch.msgid.link/20250206094657.20865-3-jack@suse.cz Signed-off-by: Theodore Ts'o <tytso@mit.edu>
1 parent 5f920d5 commit e6eff39

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

fs/jbd2/journal.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1869,7 +1869,6 @@ int jbd2_journal_update_sb_log_tail(journal_t *journal, tid_t tail_tid,
18691869

18701870
/* Log is no longer empty */
18711871
write_lock(&journal->j_state_lock);
1872-
WARN_ON(!sb->s_sequence);
18731872
journal->j_flags &= ~JBD2_FLUSHED;
18741873
write_unlock(&journal->j_state_lock);
18751874

0 commit comments

Comments
 (0)