Skip to content

Commit f96cea2

Browse files
matte-schwartzNeroReflex
authored andcommitted
[NOT-FOR-UPSTREAM] hid-asus-ally: grab short press QAM on ROG Xbox Ally X
The hid report for the QAM button changed on the ASUS ROG Xbox Ally X, so add the new mapping for the short press event. Otherwise, all we get is a long press event on "Asus Keyboard". neptune: We're carrying this as [NOT-FOR-UPSTREAM] because the last version of hid-asus-ally on lkml was in August of 2024, and we have some divergence from the last submission upstream. This should be included upstream when there is a new submission for hid-asus-ally. Reviewed-by: Derek J. Clark <derekjohn.clark@gmail.com> Signed-off-by: Matthew Schwartz <matthew.schwartz@linux.dev>
1 parent bb9925a commit f96cea2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/hid/hid-asus-ally.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1460,7 +1460,7 @@ static int ally_x_raw_event(struct ally_x_device *ally_x, struct hid_report *rep
14601460
else if (data[0] == 0x5A) {
14611461
if (ally_x->qam_btns_steam_mode) {
14621462
spin_lock_irqsave(&ally_x->lock, flags);
1463-
if (data[1] == 0x38 && !ally_x->update_qam_btn) {
1463+
if ((data[1] == 0x38 || data[1] == 0x93) && !ally_x->update_qam_btn) {
14641464
ally_x->update_qam_btn = true;
14651465
if (ally_x->output_worker_initialized)
14661466
schedule_work(&ally_x->output_worker);
@@ -1470,7 +1470,7 @@ static int ally_x_raw_event(struct ally_x_device *ally_x, struct hid_report *rep
14701470
input_report_key(ally_x->input, BTN_MODE, data[1] == 0xA6);
14711471
} else {
14721472
input_report_key(ally_x->input, KEY_F16, data[1] == 0xA6);
1473-
input_report_key(ally_x->input, KEY_PROG1, data[1] == 0x38);
1473+
input_report_key(ally_x->input, KEY_PROG1, data[1] == 0x38 || data[1] == 0x93);
14741474
}
14751475
/* QAM long press */
14761476
input_report_key(ally_x->input, KEY_F17, data[1] == 0xA7);

0 commit comments

Comments
 (0)