Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Obtainium import/export — bring your library over from Obtainium with one tap, or export to Obtainium any time.",
"Add from starred — surface APK-shipping repos from your GitHub stars and jump straight into installing.",
"Installer attribution — set what installer name silent installs claim, so apps that gate on installer source can be coaxed into running.",
"Manual refresh on details — pull-to-refresh on Android, overflow-menu Refresh on every platform, Ctrl/Cmd+R on desktop."
"Manual refresh on details — pull-to-refresh on Android, overflow-menu Refresh on every platform, Ctrl/Cmd+R on desktop.",
"Search now sorts by Recently Updated — find repos with fresh stable releases first."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix release-note claim to match actual sort behavior.

Line 19 currently says results prioritize repos with fresh stable releases, but this feature sorts by repository updated_at (recent activity). Please update the copy to avoid a misleading promise.

Proposed wording
- "Search now sorts by Recently Updated — find repos with fresh stable releases first."
+ "Search now sorts by Recently Updated — find repos with the most recent repository updates first."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"Search now sorts by Recently Updated — find repos with fresh stable releases first."
"Search now sorts by Recently Updated — find repos with the most recent repository updates first."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@core/presentation/src/commonMain/composeResources/files/whatsnew/16.json` at
line 19, Update the release-note string that currently reads "Search now sorts
by Recently Updated — find repos with fresh stable releases first." to avoid
implying it prioritizes stable releases; replace it with wording that reflects
sorting by repository activity (updated_at), for example "Search now sorts by
Recently Updated — find repos with the most recent activity first." Locate and
edit the exact JSON value containing the original sentence to perform the
change.

]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"استيراد/تصدير Obtainium: انقل مكتبتك من Obtainium بنقرة واحدة، أو صدّر إلى صيغة Obtainium في أي وقت.",
"إضافة من المُنجَّمة: استعرض المستودعات التي تشحن APK ضمن نجوم GitHub لديك وانتقل مباشرة إلى التثبيت.",
"تخصيص هوية المثبّت: عيّن اسم المثبّت الذي تدّعيه التثبيتات الصامتة، حتى تعمل التطبيقات التي تتحقّق من مصدر التثبيت.",
"تحديث يدوي على شاشة التفاصيل: السحب للتحديث على Android، وعنصر «تحديث» في قائمة الخيارات على كل المنصات، واختصار Ctrl/Cmd+R على سطح المكتب."
"تحديث يدوي على شاشة التفاصيل: السحب للتحديث على Android، وعنصر «تحديث» في قائمة الخيارات على كل المنصات، واختصار Ctrl/Cmd+R على سطح المكتب.",
"البحث يدعم الآن الترتيب حسب «المحدّث مؤخراً» — اعثر على المستودعات ذات أحدث الإصدارات المستقرّة أولاً."
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Obtainium ইম্পোর্ট/এক্সপোর্ট — এক ট্যাপে Obtainium থেকে লাইব্রেরি আনুন, বা যেকোনো সময় Obtainium ফরম্যাটে এক্সপোর্ট করুন।",
"Add from starred — আপনার GitHub স্টার করা যেসব রিপো APK পাঠায় সেগুলো দেখুন আর সরাসরি ইনস্টলে যান।",
"Installer attribution — সাইলেন্ট ইনস্টল কোন ইনস্টলার নাম দাবি করবে তা সেট করুন, যাতে যেসব অ্যাপ ইনস্টলার সোর্স দেখে সেগুলোও চলতে পারে।",
"ডিটেইলস স্ক্রিনে ম্যানুয়াল রিফ্রেশ — Android-এ পুল-টু-রিফ্রেশ, সব প্ল্যাটফর্মে ওভারফ্লো মেনুতে রিফ্রেশ, ডেস্কটপে Ctrl/Cmd+R।"
"ডিটেইলস স্ক্রিনে ম্যানুয়াল রিফ্রেশ — Android-এ পুল-টু-রিফ্রেশ, সব প্ল্যাটফর্মে ওভারফ্লো মেনুতে রিফ্রেশ, ডেস্কটপে Ctrl/Cmd+R।",
"সার্চ এখন «সাম্প্রতিক আপডেট» দিয়ে সাজানো যায় — সর্বশেষ স্থিতিশীল রিলিজ আছে এমন রিপো প্রথমে দেখুন।"
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Importar/Exportar Obtainium: trae tu biblioteca desde Obtainium con un toque, o exporta a formato Obtainium cuando quieras.",
"Añadir desde estrellas: descubre los repos de tus estrellas en GitHub que envían APK y salta directo a instalar.",
"Atribución del instalador: define qué nombre de instalador declaran las instalaciones silenciosas, para que las apps que filtran por origen del instalador funcionen.",
"Actualización manual en detalles: deslizar para actualizar en Android, opción «Actualizar» en el menú de opciones en todas las plataformas, Ctrl/Cmd+R en escritorio."
"Actualización manual en detalles: deslizar para actualizar en Android, opción «Actualizar» en el menú de opciones en todas las plataformas, Ctrl/Cmd+R en escritorio.",
"Búsqueda ordena ahora por «Actualizados recientemente» — encuentra primero los repos con releases estables más recientes."
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Import/Export Obtainium : récupérez votre bibliothèque depuis Obtainium en un toucher, ou exportez vers Obtainium quand vous voulez.",
"Ajouter depuis les étoiles : repérez parmi vos repos étoilés sur GitHub ceux qui livrent un APK, puis installez-les directement.",
"Attribution de l’installateur : choisissez le nom d’installateur que les installations silencieuses revendiquent, pour que les apps qui filtrent par source d’installation fonctionnent.",
"Actualisation manuelle dans les détails : tirer pour actualiser sur Android, entrée « Actualiser » dans le menu sur toutes les plateformes, Ctrl/Cmd+R sur le bureau."
"Actualisation manuelle dans les détails : tirer pour actualiser sur Android, entrée « Actualiser » dans le menu sur toutes les plateformes, Ctrl/Cmd+R sur le bureau.",
"La recherche peut désormais trier par « Récemment mis à jour » — trouvez d’abord les dépôts avec les releases stables les plus récentes."
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Obtainium इम्पोर्ट/एक्सपोर्ट — एक टैप से Obtainium से अपनी लाइब्रेरी लाएँ, या जब चाहें Obtainium फ़ॉर्मैट में एक्सपोर्ट करें।",
"Add from starred — अपने GitHub स्टार किए हुए रेपो में से APK वाले को सामने लाएँ और सीधे इंस्टॉल पर जाएँ।",
"Installer attribution — साइलेंट इंस्टॉल किस इंस्टॉलर नाम का दावा करेंगे, इसे सेट करें ताकि इंस्टॉलर सोर्स पर निर्भर ऐप्स भी चल सकें।",
"विवरण स्क्रीन पर मैन्युअल रीफ़्रेश — Android पर पुल-टू-रीफ़्रेश, हर प्लेटफ़ॉर्म पर ओवरफ़्लो मेन्यू में 'रीफ़्रेश', डेस्कटॉप पर Ctrl/Cmd+R।"
"विवरण स्क्रीन पर मैन्युअल रीफ़्रेश — Android पर पुल-टू-रीफ़्रेश, हर प्लेटफ़ॉर्म पर ओवरफ़्लो मेन्यू में 'रीफ़्रेश', डेस्कटॉप पर Ctrl/Cmd+R।",
"सर्च अब 'हाल ही में अपडेट किया गया' के अनुसार सॉर्ट कर सकती है — सबसे नई स्थिर रिलीज़ वाले रेपो पहले देखें।"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Release-note claim on stable-release ordering is inaccurate.

Line 19 says this sort shows repos with the newest stable release first, but the implemented behavior is GitHub sort=updated (repository activity). Please reword to avoid mismatch with actual UX.

Suggested wording (Hindi)
- "सर्च अब 'हाल ही में अपडेट किया गया' के अनुसार सॉर्ट कर सकती है — सबसे नई स्थिर रिलीज़ वाले रेपो पहले देखें।"
+ "सर्च अब 'हाल ही में अपडेट किया गया' के अनुसार सॉर्ट कर सकती है — हाल की रिपॉज़िटरी गतिविधि (जैसे push/updates) वाले रेपो पहले देखें।"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"सर्च अब 'हाल ही में अपडेट किया गया' के अनुसार सॉर्ट कर सकती है — सबसे नई स्थिर रिलीज़ वाले रेपो पहले देखें।"
"सर्च अब 'हाल ही में अपडेट किया गया' के अनुसार सॉर्ट कर सकती है — हाल की रिपॉज़िटरी गतिविधि (जैसे push/updates) वाले रेपो पहले देखें।"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@core/presentation/src/commonMain/composeResources/files/whatsnew/hi/16.json`
at line 19, The Hindi release-note string "सर्च अब 'हाल ही में अपडेट किया गया'
के अनुसार सॉर्ट कर सकती है — सबसे नई स्थिर रिलीज़ वाले रेपो पहले देखें।" in
16.json is incorrect because the product sorts by repository activity (GitHub
sort=updated), not by newest stable release; update that string to state that
results are ordered by recent activity/last updated (e.g., mention "हालिया
गतिविधि" or "हाल ही में अपडेट किया गया" meaning repos with recent updates appear
first) so the wording reflects repository activity rather than stable-release
ordering.

]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Import/Export Obtainium: porta la tua libreria da Obtainium con un tocco, o esporta verso il formato Obtainium quando vuoi.",
"Aggiungi dalle stelle: scopri i repo che spediscono APK fra le tue stelle GitHub e vai dritto all'installazione.",
"Attribuzione installatore: scegli quale nome di installatore dichiarano le installazioni silenziose, così le app che filtrano sull'origine funzionano.",
"Aggiornamento manuale nei dettagli: trascina per aggiornare su Android, voce «Aggiorna» nel menu su tutte le piattaforme, Ctrl/Cmd+R su desktop."
"Aggiornamento manuale nei dettagli: trascina per aggiornare su Android, voce «Aggiorna» nel menu su tutte le piattaforme, Ctrl/Cmd+R su desktop.",
"La ricerca può ora ordinare per «Aggiornati di recente» — trova prima i repo con le release stabili più recenti."
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Obtainium インポート/エクスポート — Obtainium のライブラリをワンタップで取り込み、いつでも Obtainium 形式で書き出し。",
"スター付きから追加 — GitHub のスター付きリポから APK を配布しているものを表示し、そのままインストールに進めます。",
"インストーラー属性 — サイレントインストール時に名乗るインストーラー名を変更でき、インストール元を見るアプリも動かせるようにします。",
"詳細画面で手動更新 — Android はプルして更新、全プラットフォームでオーバーフローメニューに「更新」、デスクトップは Ctrl/Cmd+R に対応。"
"詳細画面で手動更新 — Android はプルして更新、全プラットフォームでオーバーフローメニューに「更新」、デスクトップは Ctrl/Cmd+R に対応。",
"検索で「最近更新」順の並べ替えに対応 — 最新の安定版リリースがあるリポジトリを先に表示します。"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check all locale what's new files for version 16 to identify similar claims about "stable release" sorting

# Find all 16.json files in whatsnew directories
fd -e json '^16\.json$' --full-path 'whatsnew' --exec cat {} \; --exec echo "---" \;

Repository: OpenHub-Store/GitHub-Store

Length of output: 166


🏁 Script executed:

git ls-files | grep whatsnew | head -20

Repository: OpenHub-Store/GitHub-Store

Length of output: 1614


🏁 Script executed:

cat core/presentation/src/commonMain/composeResources/files/whatsnew/ja/16.json

Repository: OpenHub-Store/GitHub-Store

Length of output: 1711


🏁 Script executed:

cat core/presentation/src/commonMain/composeResources/files/whatsnew/16.json

Repository: OpenHub-Store/GitHub-Store

Length of output: 2379


🏁 Script executed:

cat core/presentation/src/commonMain/composeResources/files/whatsnew/es/16.json core/presentation/src/commonMain/composeResources/files/whatsnew/fr/16.json

Repository: OpenHub-Store/GitHub-Store

Length of output: 5641


🏁 Script executed:

rg 'sort.*updated' --type json --type kotlin --type ts --type js -i

Repository: OpenHub-Store/GitHub-Store

Length of output: 2937


🏁 Script executed:

cat -n feature/search/data/src/commonMain/kotlin/zed/rainxch/search/data/repository/SearchRepositoryImpl.kt | head -60

Repository: OpenHub-Store/GitHub-Store

Length of output: 3029


🏁 Script executed:

rg -A 20 'RecentlyUpdated.*return null' feature/search/data/src/commonMain/kotlin/zed/rainxch/search/data/repository/SearchRepositoryImpl.kt

Repository: OpenHub-Store/GitHub-Store

Length of output: 885


🏁 Script executed:

rg -B 5 -A 30 'sortBy == SortBy.MostForks || sortBy == SortBy.RecentlyUpdated' feature/search/data/src/commonMain/kotlin/zed/rainxch/search/data/repository/SearchRepositoryImpl.kt

Repository: OpenHub-Store/GitHub-Store

Length of output: 16417


Fix release notes text — describes stable release sorting but feature actually sorts by any repository activity.

All locale files (English, Japanese, Spanish, French, etc.) claim that the "Recently Updated" sort shows "repos with fresh/latest stable releases first," but the implementation uses GitHub's REST API sort=updated parameter, which sorts by any repository update (pushes, not releases).

The backend intentionally skips RecentlyUpdated sorting and falls back to GitHub REST API, which natively honors the sort=updated parameter — this reflects the last push to any branch, not the latest stable release.

Update the release notes across all locales to clarify that the sort reflects repository activity/updates rather than specifically stable releases:

Example correction (Japanese)
-        "検索で「最近更新」順の並べ替えに対応 — 最新の安定版リリースがあるリポジトリを先に表示します。"
+        "検索で「最近更新」順の並べ替えに対応 — 最近更新されたリポジトリを先に表示します。"

Apply similar corrections to English, Spanish, French, and other locales.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"検索で「最近更新」順の並べ替えに対応 — 最新の安定版リリースがあるリポジトリを先に表示します"
"検索で「最近更新」順の並べ替えに対応 — 最近更新されたリポジトリを先に表示します"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@core/presentation/src/commonMain/composeResources/files/whatsnew/ja/16.json`
at line 19, Update the release-note string that currently reads
"検索で「最近更新」順の並べ替えに対応 — 最新の安定版リリースがあるリポジトリを先に表示します。" to state that the "最近更新" sort
orders by repository activity/last update (pushes/any updates), not by latest
stable release; apply the equivalent wording change to the same message key in
all locale files (English, Spanish, French, etc.) so they accurately reflect use
of GitHub's sort=updated behavior rather than releases.

]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Obtainium 가져오기/내보내기 — Obtainium 라이브러리를 한 번에 가져오거나, 언제든지 Obtainium 형식으로 내보낼 수 있습니다.",
"별표한 저장소에서 추가 — GitHub 별표 저장소 중 APK를 배포하는 곳을 보여주고, 바로 설치 단계로 넘어갈 수 있습니다.",
"설치자 속성 — 무음 설치가 어떤 설치자 이름을 사용할지 지정해서, 설치 출처를 확인하는 앱도 실행될 수 있도록 합니다.",
"세부 정보 화면에서 수동 새로 고침 — Android에서 당겨서 새로 고침, 모든 플랫폼의 오버플로 메뉴에 ‘새로 고침’, 데스크톱에서 Ctrl/Cmd+R."
"세부 정보 화면에서 수동 새로 고침 — Android에서 당겨서 새로 고침, 모든 플랫폼의 오버플로 메뉴에 ‘새로 고침’, 데스크톱에서 Ctrl/Cmd+R.",
"검색에서 ‘최근 업데이트’ 정렬을 추가했습니다 — 최신 안정 릴리스가 있는 저장소를 먼저 보여줍니다."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Correct the sort description to match actual behavior.

Line 19 currently says the sort prioritizes repositories with the latest stable releases, but this feature uses GitHub sort=updated (recent repository updates/activity). Please adjust wording to avoid misleading users.

Suggested text update
-        "검색에서 ‘최근 업데이트’ 정렬을 추가했습니다 — 최신 안정 릴리스가 있는 저장소를 먼저 보여줍니다."
+        "검색에서 ‘최근 업데이트’ 정렬을 추가했습니다 — 최근에 업데이트된 저장소를 먼저 보여줍니다."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"검색에서 최근 업데이트 정렬을 추가했습니다 — 최신 안정 릴리스가 있는 저장소를 먼저 보여줍니다."
"검색에서 '최근 업데이트' 정렬을 추가했습니다 — 최근에 업데이트된 저장소를 먼저 보여줍니다."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@core/presentation/src/commonMain/composeResources/files/whatsnew/ko/16.json`
at line 19, Update the Korean text on line containing "검색에서 ‘최근 업데이트’ 정렬을 추가했습니다
— 최신 안정 릴리스가 있는 저장소를 먼저 보여줍니다." to accurately describe the behavior: state that
the sort uses GitHub's recent activity (sort=updated) and prioritizes
repositories with recent updates/activity rather than those with the latest
stable releases; replace the misleading phrase "최신 안정 릴리스가 있는 저장소를 먼저 보여줍니다"
with a phrase like "최근에 업데이트되거나 활동이 있었던 저장소를 먼저 보여줍니다" so the message reflects
the actual GitHub sort behavior in 16.json.

]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Import/Eksport Obtainium — przenieś bibliotekę z Obtainium jednym dotknięciem albo wyeksportuj do formatu Obtainium kiedy chcesz.",
"Dodaj z oznaczonych gwiazdką — zobacz, które z twoich oznaczonych repo GitHub publikują APK, i przejdź wprost do instalacji.",
"Atrybucja instalatora — ustaw nazwę instalatora, którą deklarują ciche instalacje, by aplikacje filtrujące po źródle instalacji działały.",
"Ręczne odświeżanie w szczegółach — pociągnij, aby odświeżyć na Androidzie, pozycja „Odśwież” w menu na każdej platformie, Ctrl/Cmd+R na pulpicie."
"Ręczne odświeżanie w szczegółach — pociągnij, aby odświeżyć na Androidzie, pozycja „Odśwież” w menu na każdej platformie, Ctrl/Cmd+R na pulpicie.",
"Wyszukiwarka sortuje teraz po „Ostatnio zaktualizowane” — najpierw repozytoria z najświeższymi stabilnymi wydaniami."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Correct the behavior description in Polish release notes.

Line 19 currently says sorting is by latest stable releases, but this feature sorts by repository recent updates/activity (updated_at). Please adjust wording to avoid misleading users.

Suggested wording update
-        "Wyszukiwarka sortuje teraz po „Ostatnio zaktualizowane” — najpierw repozytoria z najświeższymi stabilnymi wydaniami."
+        "Wyszukiwarka sortuje teraz po „Ostatnio zaktualizowane” — najpierw repozytoria z najnowszą aktywnością (aktualizacjami)."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"Wyszukiwarka sortuje teraz po „Ostatnio zaktualizowane — najpierw repozytoria z najświeższymi stabilnymi wydaniami."
"Wyszukiwarka sortuje teraz po „Ostatnio zaktualizowane" — najpierw repozytoria z najnowszą aktywnością (aktualizacjami)."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@core/presentation/src/commonMain/composeResources/files/whatsnew/pl/16.json`
at line 19, Replace the Polish release-note string "Wyszukiwarka sortuje teraz
po „Ostatnio zaktualizowane” — najpierw repozytoria z najświeższymi stabilnymi
wydaniami." with wording that correctly reflects sorting by repository
activity/updated_at, e.g. "Wyszukiwarka sortuje teraz po „Ostatnio
zaktualizowane” — najpierw repozytoria z ostatnią aktywnością (pole
updated_at)." Locate and update the exact string occurrence in the JSON so it no
longer mentions "stabilnymi wydaniami."

]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Импорт/Экспорт Obtainium — перенесите библиотеку из Obtainium одним касанием или выгрузите в формат Obtainium в любой момент.",
"Добавление из звёзд — видите среди ваших звёзд GitHub репозитории с APK и сразу переходите к установке.",
"Атрибуция установщика — задайте имя установщика, которым представляются тихие установки, чтобы работали приложения, проверяющие источник установки.",
"Ручное обновление на экране деталей — потяните вниз для обновления на Android, пункт «Обновить» в меню на всех платформах, Ctrl/Cmd+R на десктопе."
"Ручное обновление на экране деталей — потяните вниз для обновления на Android, пункт «Обновить» в меню на всех платформах, Ctrl/Cmd+R на десктопе.",
"Поиск теперь умеет сортировать по «Недавно обновлённым» — репозитории с самыми свежими стабильными релизами выводятся первыми."
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Obtainium içe/dışa aktarma — Obtainium kütüphanenizi tek dokunuşla getirin ya da istediğiniz zaman Obtainium biçiminde dışa aktarın.",
"Yıldızlananlardan ekle — GitHub'da yıldızladıklarınız arasından APK gönderenleri görüp doğrudan kuruluma geçin.",
"Yükleyici atfı — sessiz kurulumların hangi yükleyici adını taşıyacağını ayarlayın; kurulum kaynağını kontrol eden uygulamalar yine çalışsın.",
"Detaylar ekranında manuel yenileme — Android'de aşağı çek-yenile, her platformda taşma menüsünde 'Yenile' seçeneği, masaüstünde Ctrl/Cmd+R."
"Detaylar ekranında manuel yenileme — Android'de aşağı çek-yenile, her platformda taşma menüsünde 'Yenile' seçeneği, masaüstünde Ctrl/Cmd+R.",
"Arama artık 'Yeni Güncellenmiş' sırasıyla sıralanabiliyor — en yeni kararlı sürümlere sahip depoları önce görün."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

“Kararlı sürüm” ifadesi davranışı yanlış temsil ediyor.

Bu metin, sıralamanın kararlı sürüm tarihine göre olduğunu söylüyor; PR kapsamındaki gerçek davranış ise GitHub updated_at (repo aktivitesi/push vb.) sıralaması. Kullanıcı beklentisini yanlış yönlendirmemek için metni buna göre düzeltelim.

Önerilen metin güncellemesi
-        "Arama artık 'Yeni Güncellenmiş' sırasıyla sıralanabiliyor — en yeni kararlı sürümlere sahip depoları önce görün."
+        "Arama artık 'Yeni Güncellenmiş' sırasıyla sıralanabiliyor — yakın zamanda güncellenen depoları önce görün."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"Arama artık 'Yeni Güncellenmiş' sırasıyla sıralanabiliyor — en yeni kararlı sürümlere sahip depoları önce görün."
"Arama artık 'Yeni Güncellenmiş' sırasıyla sıralanabiliyor — yakın zamanda güncellenen depoları önce görün."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@core/presentation/src/commonMain/composeResources/files/whatsnew/tr/16.json`
at line 19, The current Turkish string "Arama artık 'Yeni Güncellenmiş'
sırasıyla sıralanabiliyor — en yeni kararlı sürümlere sahip depoları önce
görün." incorrectly mentions "kararlı sürüm"; update this JSON value in
core/presentation/src/commonMain/composeResources/files/whatsnew/tr/16.json to
state that sorting uses the repository's last updated timestamp (GitHub
updated_at) instead of stable release date — e.g., replace the sentence to
something like "Arama artık 'Yeni Güncellenmiş' sırasına göre sıralanabiliyor —
en son güncellenen depoları önce görün." ensuring the string precisely replaces
the existing text.

]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Obtainium 导入/导出:一键从 Obtainium 迁移你的应用库,也可以随时导出为 Obtainium 格式。",
"从星标添加:列出你 GitHub 星标里发布 APK 的仓库,直接跳到安装环节。",
"安装来源伪装:可设置静默安装时声明的安装器名称,让那些根据安装来源做判断的应用也能正常运行。",
"详情页手动刷新:Android 下拉刷新,所有平台的溢出菜单都加入「刷新」,桌面端支持 Ctrl/Cmd+R。"
"详情页手动刷新:Android 下拉刷新,所有平台的溢出菜单都加入「刷新」,桌面端支持 Ctrl/Cmd+R。",
"搜索新增「最近更新」排序 — 优先展示有最新稳定版本的仓库。"
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,9 @@ class SearchRepositoryImpl(
): PaginatedDiscoveryRepositories? {
if (query.isBlank()) return null

// Backend doesn't support forks sorting — fall through to GitHub REST
if (sortBy == SortBy.MostForks) return null
// Backend doesn't support forks or recently-updated sorting —
// fall through to GitHub REST which honors both natively.
if (sortBy == SortBy.MostForks || sortBy == SortBy.RecentlyUpdated) return null

val platformSlug = when (platform) {
DiscoveryPlatform.Android -> "android"
Expand All @@ -127,6 +128,7 @@ class SearchRepositoryImpl(
SortBy.MostStars -> "stars"
SortBy.BestMatch -> "relevance"
SortBy.MostForks -> null // unreachable, guarded above
SortBy.RecentlyUpdated -> null // unreachable, guarded above
}

val offset = (page - 1) * BACKEND_PAGE_SIZE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@ enum class SortBy {
MostStars,
MostForks,
BestMatch,
RecentlyUpdated,
;

fun toGithubSortParam(): String? =
when (this) {
MostStars -> "stars"
MostForks -> "forks"
BestMatch -> null
RecentlyUpdated -> "updated"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@ fun SortByUi.toDomain(): SortBy {
SortByUi.MostStars -> MostStars
SortByUi.MostForks -> MostForks
SortByUi.BestMatch -> BestMatch
SortByUi.RecentlyUpdated -> RecentlyUpdated
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ enum class SortByUi {
MostStars,
MostForks,
BestMatch,
RecentlyUpdated,
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ fun SortByUi.label(): StringResource =
MostStars -> Res.string.sort_most_stars
MostForks -> Res.string.sort_most_forks
BestMatch -> Res.string.sort_best_match
RecentlyUpdated -> Res.string.sort_recently_updated
}