-
-
Notifications
You must be signed in to change notification settings - Fork 500
feat(search): add Recently Updated sort option (closes #392) #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -15,7 +15,8 @@ | |||||
| "Obtainium इम्पोर्ट/एक्सपोर्ट — एक टैप से Obtainium से अपनी लाइब्रेरी लाएँ, या जब चाहें Obtainium फ़ॉर्मैट में एक्सपोर्ट करें।", | ||||||
| "Add from starred — अपने GitHub स्टार किए हुए रेपो में से APK वाले को सामने लाएँ और सीधे इंस्टॉल पर जाएँ।", | ||||||
| "Installer attribution — साइलेंट इंस्टॉल किस इंस्टॉलर नाम का दावा करेंगे, इसे सेट करें ताकि इंस्टॉलर सोर्स पर निर्भर ऐप्स भी चल सकें।", | ||||||
| "विवरण स्क्रीन पर मैन्युअल रीफ़्रेश — Android पर पुल-टू-रीफ़्रेश, हर प्लेटफ़ॉर्म पर ओवरफ़्लो मेन्यू में 'रीफ़्रेश', डेस्कटॉप पर Ctrl/Cmd+R।" | ||||||
| "विवरण स्क्रीन पर मैन्युअल रीफ़्रेश — Android पर पुल-टू-रीफ़्रेश, हर प्लेटफ़ॉर्म पर ओवरफ़्लो मेन्यू में 'रीफ़्रेश', डेस्कटॉप पर Ctrl/Cmd+R।", | ||||||
| "सर्च अब 'हाल ही में अपडेट किया गया' के अनुसार सॉर्ट कर सकती है — सबसे नई स्थिर रिलीज़ वाले रेपो पहले देखें।" | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Release-note claim on stable-release ordering is inaccurate. Line 19 says this sort shows repos with the newest stable release first, but the implemented behavior is GitHub Suggested wording (Hindi)- "सर्च अब 'हाल ही में अपडेट किया गया' के अनुसार सॉर्ट कर सकती है — सबसे नई स्थिर रिलीज़ वाले रेपो पहले देखें।"
+ "सर्च अब 'हाल ही में अपडेट किया गया' के अनुसार सॉर्ट कर सकती है — हाल की रिपॉज़िटरी गतिविधि (जैसे push/updates) वाले रेपो पहले देखें।"📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -15,7 +15,8 @@ | |||||
| "Obtainium インポート/エクスポート — Obtainium のライブラリをワンタップで取り込み、いつでも Obtainium 形式で書き出し。", | ||||||
| "スター付きから追加 — GitHub のスター付きリポから APK を配布しているものを表示し、そのままインストールに進めます。", | ||||||
| "インストーラー属性 — サイレントインストール時に名乗るインストーラー名を変更でき、インストール元を見るアプリも動かせるようにします。", | ||||||
| "詳細画面で手動更新 — Android はプルして更新、全プラットフォームでオーバーフローメニューに「更新」、デスクトップは Ctrl/Cmd+R に対応。" | ||||||
| "詳細画面で手動更新 — Android はプルして更新、全プラットフォームでオーバーフローメニューに「更新」、デスクトップは Ctrl/Cmd+R に対応。", | ||||||
| "検索で「最近更新」順の並べ替えに対応 — 最新の安定版リリースがあるリポジトリを先に表示します。" | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Description: Check all locale what's new files for version 16 to identify similar claims about "stable release" sorting
# Find all 16.json files in whatsnew directories
fd -e json '^16\.json$' --full-path 'whatsnew' --exec cat {} \; --exec echo "---" \;Repository: OpenHub-Store/GitHub-Store Length of output: 166 🏁 Script executed: git ls-files | grep whatsnew | head -20Repository: OpenHub-Store/GitHub-Store Length of output: 1614 🏁 Script executed: cat core/presentation/src/commonMain/composeResources/files/whatsnew/ja/16.jsonRepository: OpenHub-Store/GitHub-Store Length of output: 1711 🏁 Script executed: cat core/presentation/src/commonMain/composeResources/files/whatsnew/16.jsonRepository: OpenHub-Store/GitHub-Store Length of output: 2379 🏁 Script executed: cat core/presentation/src/commonMain/composeResources/files/whatsnew/es/16.json core/presentation/src/commonMain/composeResources/files/whatsnew/fr/16.jsonRepository: OpenHub-Store/GitHub-Store Length of output: 5641 🏁 Script executed: rg 'sort.*updated' --type json --type kotlin --type ts --type js -iRepository: OpenHub-Store/GitHub-Store Length of output: 2937 🏁 Script executed: cat -n feature/search/data/src/commonMain/kotlin/zed/rainxch/search/data/repository/SearchRepositoryImpl.kt | head -60Repository: OpenHub-Store/GitHub-Store Length of output: 3029 🏁 Script executed: rg -A 20 'RecentlyUpdated.*return null' feature/search/data/src/commonMain/kotlin/zed/rainxch/search/data/repository/SearchRepositoryImpl.ktRepository: OpenHub-Store/GitHub-Store Length of output: 885 🏁 Script executed: rg -B 5 -A 30 'sortBy == SortBy.MostForks || sortBy == SortBy.RecentlyUpdated' feature/search/data/src/commonMain/kotlin/zed/rainxch/search/data/repository/SearchRepositoryImpl.ktRepository: OpenHub-Store/GitHub-Store Length of output: 16417 Fix release notes text — describes stable release sorting but feature actually sorts by any repository activity. All locale files (English, Japanese, Spanish, French, etc.) claim that the "Recently Updated" sort shows "repos with fresh/latest stable releases first," but the implementation uses GitHub's REST API The backend intentionally skips RecentlyUpdated sorting and falls back to GitHub REST API, which natively honors the Update the release notes across all locales to clarify that the sort reflects repository activity/updates rather than specifically stable releases: Example correction (Japanese)- "検索で「最近更新」順の並べ替えに対応 — 最新の安定版リリースがあるリポジトリを先に表示します。"
+ "検索で「最近更新」順の並べ替えに対応 — 最近更新されたリポジトリを先に表示します。"Apply similar corrections to English, Spanish, French, and other locales. 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -15,7 +15,8 @@ | |||||
| "Obtainium 가져오기/내보내기 — Obtainium 라이브러리를 한 번에 가져오거나, 언제든지 Obtainium 형식으로 내보낼 수 있습니다.", | ||||||
| "별표한 저장소에서 추가 — GitHub 별표 저장소 중 APK를 배포하는 곳을 보여주고, 바로 설치 단계로 넘어갈 수 있습니다.", | ||||||
| "설치자 속성 — 무음 설치가 어떤 설치자 이름을 사용할지 지정해서, 설치 출처를 확인하는 앱도 실행될 수 있도록 합니다.", | ||||||
| "세부 정보 화면에서 수동 새로 고침 — Android에서 당겨서 새로 고침, 모든 플랫폼의 오버플로 메뉴에 ‘새로 고침’, 데스크톱에서 Ctrl/Cmd+R." | ||||||
| "세부 정보 화면에서 수동 새로 고침 — Android에서 당겨서 새로 고침, 모든 플랫폼의 오버플로 메뉴에 ‘새로 고침’, 데스크톱에서 Ctrl/Cmd+R.", | ||||||
| "검색에서 ‘최근 업데이트’ 정렬을 추가했습니다 — 최신 안정 릴리스가 있는 저장소를 먼저 보여줍니다." | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct the sort description to match actual behavior. Line 19 currently says the sort prioritizes repositories with the latest stable releases, but this feature uses GitHub Suggested text update- "검색에서 ‘최근 업데이트’ 정렬을 추가했습니다 — 최신 안정 릴리스가 있는 저장소를 먼저 보여줍니다."
+ "검색에서 ‘최근 업데이트’ 정렬을 추가했습니다 — 최근에 업데이트된 저장소를 먼저 보여줍니다."📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -15,7 +15,8 @@ | |||||
| "Import/Eksport Obtainium — przenieś bibliotekę z Obtainium jednym dotknięciem albo wyeksportuj do formatu Obtainium kiedy chcesz.", | ||||||
| "Dodaj z oznaczonych gwiazdką — zobacz, które z twoich oznaczonych repo GitHub publikują APK, i przejdź wprost do instalacji.", | ||||||
| "Atrybucja instalatora — ustaw nazwę instalatora, którą deklarują ciche instalacje, by aplikacje filtrujące po źródle instalacji działały.", | ||||||
| "Ręczne odświeżanie w szczegółach — pociągnij, aby odświeżyć na Androidzie, pozycja „Odśwież” w menu na każdej platformie, Ctrl/Cmd+R na pulpicie." | ||||||
| "Ręczne odświeżanie w szczegółach — pociągnij, aby odświeżyć na Androidzie, pozycja „Odśwież” w menu na każdej platformie, Ctrl/Cmd+R na pulpicie.", | ||||||
| "Wyszukiwarka sortuje teraz po „Ostatnio zaktualizowane” — najpierw repozytoria z najświeższymi stabilnymi wydaniami." | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct the behavior description in Polish release notes. Line 19 currently says sorting is by latest stable releases, but this feature sorts by repository recent updates/activity ( Suggested wording update- "Wyszukiwarka sortuje teraz po „Ostatnio zaktualizowane” — najpierw repozytoria z najświeższymi stabilnymi wydaniami."
+ "Wyszukiwarka sortuje teraz po „Ostatnio zaktualizowane” — najpierw repozytoria z najnowszą aktywnością (aktualizacjami)."📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -15,7 +15,8 @@ | |||||
| "Obtainium içe/dışa aktarma — Obtainium kütüphanenizi tek dokunuşla getirin ya da istediğiniz zaman Obtainium biçiminde dışa aktarın.", | ||||||
| "Yıldızlananlardan ekle — GitHub'da yıldızladıklarınız arasından APK gönderenleri görüp doğrudan kuruluma geçin.", | ||||||
| "Yükleyici atfı — sessiz kurulumların hangi yükleyici adını taşıyacağını ayarlayın; kurulum kaynağını kontrol eden uygulamalar yine çalışsın.", | ||||||
| "Detaylar ekranında manuel yenileme — Android'de aşağı çek-yenile, her platformda taşma menüsünde 'Yenile' seçeneği, masaüstünde Ctrl/Cmd+R." | ||||||
| "Detaylar ekranında manuel yenileme — Android'de aşağı çek-yenile, her platformda taşma menüsünde 'Yenile' seçeneği, masaüstünde Ctrl/Cmd+R.", | ||||||
| "Arama artık 'Yeni Güncellenmiş' sırasıyla sıralanabiliyor — en yeni kararlı sürümlere sahip depoları önce görün." | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. “Kararlı sürüm” ifadesi davranışı yanlış temsil ediyor. Bu metin, sıralamanın kararlı sürüm tarihine göre olduğunu söylüyor; PR kapsamındaki gerçek davranış ise GitHub Önerilen metin güncellemesi- "Arama artık 'Yeni Güncellenmiş' sırasıyla sıralanabiliyor — en yeni kararlı sürümlere sahip depoları önce görün."
+ "Arama artık 'Yeni Güncellenmiş' sırasıyla sıralanabiliyor — yakın zamanda güncellenen depoları önce görün."📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,4 +4,5 @@ enum class SortByUi { | |
| MostStars, | ||
| MostForks, | ||
| BestMatch, | ||
| RecentlyUpdated, | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix release-note claim to match actual sort behavior.
Line 19 currently says results prioritize repos with fresh stable releases, but this feature sorts by repository
updated_at(recent activity). Please update the copy to avoid a misleading promise.Proposed wording
📝 Committable suggestion
🤖 Prompt for AI Agents