Merged
Conversation
tpazderka
force-pushed
the
decrease-complexity-saml
branch
2 times, most recently
from
eb97060 to
1d9a086
Compare
Contributor
|
Hey, I thought we were going to make these small!? A 300+ line diff is not easy to review ;) |
Collaborator
Author
|
The only change is that the |
Importing oic.utils.authn.saml without saml2 raises ImportError
tpazderka
force-pushed
the
decrease-complexity-saml
branch
from
1d9a086 to
9df5e5c
Compare
Collaborator
Author
|
I do recommend doing the review from cmommandline using |
Contributor
|
Ah yes, thanks (didn't know about that option!)! Yes, I agree with this change, LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md.Ref #311