M #-: Various improvements (#255)

- improve reboot vs ssh-reconnect race, avoid sleep
- don't rely on selinux-relabel via virt-sysprep this requires specific kernel, better reboot+relabel within Packer provision
- remove insights-client in RHEL, it causes issues in infra

Author: xorel

packer/alma/11-update-grub.sh

@@ -55,4 +55,7 @@ grub2-mkconfig -o /boot/grub2/grub.cfg
 
 sync
 
+# Avoid  reboot vs. packer-ssh-reconnect race
+systemctl stop sshd
+
 reboot

packer/alma/11-zzz.sh

@@ -7,4 +7,7 @@ sed -i -e 's:^SELINUX=.*:SELINUX=permissive:' /etc/selinux/config
 
 fixfiles -F onboot
 
+# Avoid  reboot vs. packer-ssh-reconnect race
+systemctl stop sshd
+
 reboot

packer/fedora/12-selinux-fixfiles.sh

@@ -53,4 +53,7 @@ grub2-mkconfig -o /boot/grub2/grub.cfg
 
 sync
 
+# Avoid  reboot vs. packer-ssh-reconnect race
+systemctl stop sshd
+
 reboot

packer/fedora/12-zzz.sh

@@ -53,6 +53,12 @@ dracut --force "$INITRAMFS_IMG" "$INITRAMFS_VER"
 
 grub2-mkconfig -o /boot/grub2/grub.cfg
 
+# force relinux relabel
+fixfiles -F onboot
+
 sync
 
+# Avoid  reboot vs. packer-ssh-reconnect race
+systemctl stop sshd
+
 reboot

packer/ol/11-update-grub.sh

@@ -10,7 +10,7 @@ systemctl disable kdump.service
 # Remove old kernels.
 dnf remove -y $(dnf repoquery --installonly --latest-limit=-1 -q)
 
-dnf remove -y linux-firmware
+dnf remove -y linux-firmware insights-client
 
 dnf clean -y all
 

packer/ol/11-zzz.sh

@@ -57,4 +57,7 @@ grub2-mkconfig -o /boot/grub2/grub.cfg
 
 sync
 
+# Avoid  reboot vs. packer-ssh-reconnect race
+systemctl stop sshd
+
 reboot