Skip to content

TaboolaClient Requests Timeout#3

Merged
jsu merged 1 commit into
masterfrom
jsu/DENG-TaboolaClient_Requests_Timeout
Apr 27, 2020
Merged

TaboolaClient Requests Timeout#3
jsu merged 1 commit into
masterfrom
jsu/DENG-TaboolaClient_Requests_Timeout

Conversation

@jsu
Copy link
Copy Markdown

@jsu jsu commented Apr 27, 2020

Summary

  1. Taboola API endpoints have been flakey lately. As we don't have timeout being passed / set to requests. The default behavior is to wait forever. Here we add timeout available to be set during construction.
  2. The default value for requests.timeout is None. Requests Doc

Deployment Instructions

  1. I don't know.

@jsu jsu merged commit d67f16b into master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants