Added Version Retrieval to LIFU Interface#305
Closed
georgevigelette wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
The changes to test_watertank.py don't seem related to #305. Can you remove them from this PR?
| import openlifu as m | ||
| return getattr(m, "__version__", "0.3.2") | ||
| except ImportError: | ||
| return "0.3.2" |
Contributor
There was a problem hiding this comment.
Are these fallbacks necessary? Is there an expected case where openlifu doesn't import or doesn't have a __version__?
peterhollender
requested changes
Jul 22, 2025
Contributor
peterhollender
left a comment
peterhollender
left a comment
There was a problem hiding this comment.
I think we can reduce this to just the minimum for get_sdk_version without the additional script updates and fallbacks.
Collaborator
|
I am guessing this was meant to be overridden by #379 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights
added SDK version retrieval
updated watertank script not to output prints every time it calls get temperature