Avoid tokenizer exception when parsing VHDL attributes#54
Merged
Conversation
skaupper
force-pushed
the
bugfix/vhdl_attributes
branch
from
0711ea7 to
03280b8
Compare
Paebbels
reviewed
Jun 20, 2023
skaupper
force-pushed
the
bugfix/vhdl_attributes
branch
from
03280b8 to
687d3f6
Compare
…le quote, and nothing else
skaupper
force-pushed
the
bugfix/vhdl_attributes
branch
from
687d3f6 to
519f9af
Compare
Author
|
I removed the change to InterfaceObject.py and rebased my branch to For some tests to run successfully (the issue specific tests), I had to extend the equality and inequality operators of the |
Paebbels
approved these changes
Jun 20, 2023
This was referenced Jun 20, 2023
Open
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I also ran into the problem described by #4 and #18, I went ahead and applied the fix of #26.
An additional testcase in Tokens.py should catch regressions.
PS: While running the tests using pytest, a completely independent testcase failed for me. Seems like you commented the code on purpose. Maybe it was a mistake?