Analyzer warnings for static handler classes#7663
Merged
Merged
Conversation
4afe2ef to
8db910f
Compare
andreasohlund
approved these changes
Mar 20, 2026
This was referenced May 21, 2026
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new analyzer diagnostic to prevent static classes from being used as handler classes in NServiceBus, ensuring that only non-static classes are allowed for handler registration via the
[Handler]attribute or convention-based mechanisms. The changes add enforcement in both the analyzer logic and the code generation pipeline, as well as new tests to verify the behavior.Analyzer and Diagnostic Improvements:
NSB0038(HandlerClassCannotBeStatic) to identify and report static handler classes. [1] [2]HandlerAttributeAnalyzerto report the new diagnostic when a static class is decorated with the[Handler]attribute or detected as a convention-based handler. [1] [2] [3]Code Generation and Parsing Adjustments:
Testing Enhancements: