Feature/Update documentation for optional update IDs#814
Merged
Conversation
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
figueroa1395
changed the base branch from
main
to
feature/columnar-data-support-no-id-field
Member
Author
|
Documentation and the columnar-data related example can be reviewed already. Meta data will be cleaned up at the end if necessary, but feel free to already point things out. |
mgovers
reviewed
Oct 30, 2024
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
figueroa1395
changed the base branch from
feature/columnar-data-support-no-id-field
to
feature/row-update-data-support-no-id-field
…col-update-optional-id
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
…col-update-optional-id
…col-update-optional-id
Base automatically changed from
feature/row-update-data-support-no-id-field
to
feature/columnar-data-support-no-id-field
November 5, 2024 14:09
…l-update-optional-id
mgovers
reviewed
Nov 5, 2024
…l-update-optional-id
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
mgovers
previously approved these changes
Nov 5, 2024
Jerry-Jinfeng-Guo
previously approved these changes
Nov 5, 2024
Jerry-Jinfeng-Guo
changed the base branch from
feature/columnar-data-support-no-id-field
to
main
Jerry-Jinfeng-Guo
dismissed
mgovers’s stale review
The base branch was changed.
Jerry-Jinfeng-Guo
previously approved these changes
Nov 5, 2024
Member
Jerry-Jinfeng-Guo
left a comment
Jerry-Jinfeng-Guo
left a comment
There was a problem hiding this comment.
The automatic rebase to main didn't happen. Hence this manual op.
figueroa1395
dismissed
Jerry-Jinfeng-Guo’s stale review
The merge-base changed after approval.
mgovers
previously approved these changes
Nov 6, 2024
This was referenced Nov 6, 2024
Closed
mgovers
reviewed
Nov 6, 2024
Member
Author
mgovers
reviewed
Nov 7, 2024
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com>
|
mgovers
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds documentation for #771 and #813.
Closes #548
Todo: