Add caching, sequencing and optional id support on a per-component-basis#820
Merged
mgovers merged 14 commits intoNov 7, 2024
Merged
Conversation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
force-pushed
the
bug/fix-mixed-optional-id
branch
from
5c4d3cc to
6fc9294
Compare
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
commented
Nov 6, 2024
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
4 tasks
mgovers
force-pushed
the
bug/fix-mixed-optional-id
branch
from
518454c to
4255b4d
Compare
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
figueroa1395
reviewed
Nov 6, 2024
Member
figueroa1395
left a comment
figueroa1395
left a comment
There was a problem hiding this comment.
I still haven't reviewed the c++ tests (will do tomorrow morning), but the rest is reviewed. It looks good, and the tests pass! Most comments are mostly for my understanding.
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
figueroa1395
reviewed
Nov 7, 2024
Member
figueroa1395
left a comment
figueroa1395
left a comment
There was a problem hiding this comment.
Finished reviewing the (remaining) tests, with only some minor comments. Looks good to me.
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
added a commit
that referenced
this pull request
Nov 7, 2024
Add caching, sequencing and optional id support on a per-component-basis Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements step 7i of #548 .