Skip to content

Commit 976fe1d

Browse files
authored
Merge pull request #690 from tblivet/feat/improvements-part-3
[IMPROVEMENTS - PART 3] Global quality improvement
2 parents 22d41d0 + 03ca04f commit 976fe1d

File tree

36 files changed

+56
-56
lines changed

36 files changed

+56
-56
lines changed

.github/workflows/tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ jobs:
99
js: [ '20' ]
1010
steps:
1111
- name: Setup Node
12-
uses: actions/setup-node@v3
12+
uses: actions/setup-node@v4
1313
with:
1414
node-version: ${{ matrix.js }}
1515

1616
- name: Checkout
17-
uses: actions/checkout@v2
17+
uses: actions/checkout@v4
1818

1919
- name: Cache Node Directory
20-
uses: actions/cache@v2
20+
uses: actions/cache@v4
2121
with:
2222
path: ~/.npm
2323
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}

modules/blockwishlist/views/templates/components/modals/add-to-wishlist.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141

4242
<div class="modal-footer">
4343
<div role="button" @click="openNewWishlistModal" class="wishlist-add-to-new text-primary">
44-
<i class="material-icons text-primary" aria-hidden="true">add_circle_outline</i> {$newWishlistCTA}
44+
<i class="material-icons text-primary" aria-hidden="true">&#xE148;</i> {$newWishlistCTA}
4545
</div>
4646
</div>
4747
</div>

modules/blockwishlist/views/templates/hook/displayCustomerAccount.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
<a class="col-md-6 col-lg-4{if $urls.current_url === $url} active{/if}" id="wishlist-link" href="{$url}">
2121
<span class="link-item">
22-
<i class="material-icons" aria-hidden="true">favorite</i>
22+
<i class="material-icons" aria-hidden="true">&#xE87D;</i>
2323
{$wishlistsTitlePage}
2424
</span>
2525
</a>

modules/productcomments/views/templates/hook/product-comments-list.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
<ul class="pagination justify-content-center">
4141
{assign var = "prevCount" value = 0}
4242
<li class="page-item" id="pcl_page_{$prevCount}">
43-
<button class="page-link btn prev"><i class="material-icons">chevron_left</i></button>
43+
<button class="page-link btn prev"><i class="material-icons">&#xE5CB;</i></button>
4444
</li>
4545
{for $pageCount = 1 to $list_total_pages}
4646
<li class="page-item" id="pcl_page_{$pageCount}">
@@ -49,7 +49,7 @@
4949
{/for}
5050
{assign var = "nextCount" value = $list_total_pages + 1}
5151
<li class="page-item" id="pcl_page_{$nextCount}">
52-
<button class="page-link btn next"><i class="material-icons">chevron_right</i></button>
52+
<button class="page-link btn next"><i class="material-icons">&#xE5CC;</i></button>
5353
</li>
5454
</ul>
5555
</nav>

modules/ps_brandlist/views/templates/_partials/brand_form.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
aria-haspopup="true"
1212
aria-expanded="false">
1313
{l s='All brands' d='Shop.Theme.Catalog'}
14-
<i class="material-icons float-end" aria-hidden="true">arrow_drop_down</i>
14+
<i class="material-icons float-end" aria-hidden="true">&#xE5C5;</i>
1515
</button>
1616
<div class="dropdown-menu dropdown-menu-start">
1717
{foreach from=$brands item=brand}

modules/ps_contactinfo/ps_contactinfo.tpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
<div role="button" class="footer__block__toggle d-md-none collapsed" data-bs-target="#contact-infos" data-bs-toggle="collapse" aria-expanded="false">
1010
<span class="footer__block__title">{l s='Store information' d='Shop.Theme.Global'}</span>
11-
<i class="material-icons" aria-hidden="true">keyboard_arrow_down</i>
11+
<i class="material-icons" aria-hidden="true">&#xE313;</i>
1212
</div>
1313

1414
<div id="contact-infos" class="footer__block__content footer__block__content-contact collapse">
@@ -19,7 +19,7 @@
1919

2020
{if $contact_infos.phone}
2121
<div class="ps-contactinfo__phone">
22-
<i class="material-icons" aria-hidden="true">phone</i>
22+
<i class="material-icons" aria-hidden="true">&#xE0CD;</i>
2323
<a href="tel:{$contact_infos.phone}">{$contact_infos.phone}</a>
2424
</div>
2525
{/if}
@@ -33,7 +33,7 @@
3333

3434
{if $contact_infos.email && $display_email}
3535
<div class="ps-contactinfo__email">
36-
<i class="material-icons" aria-hidden="true">mail</i>
36+
<i class="material-icons" aria-hidden="true">&#xE158;</i>
3737
{mailto address=$contact_infos.email encode="javascript"}
3838
</div>
3939
{/if}

modules/ps_customeraccountlinks/ps_customeraccountlinks.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
<div role="button" class="footer__block__toggle d-md-none collapsed" data-bs-target="#footer_account_list" data-bs-toggle="collapse" aria-expanded="false">
1414
<span class="footer__block__title">{l s='Your account' d='Shop.Theme.Customeraccount'}</span>
15-
<i class="material-icons" aria-hidden="true">keyboard_arrow_down</i>
15+
<i class="material-icons" aria-hidden="true">&#xE313;</i>
1616
</div>
1717
<ul class="footer__block__content footer__block__content-list collapse" id="footer_account_list">
1818
{if $customer.is_logged}

modules/ps_customersignin/ps_customersignin.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
aria-haspopup="true"
1717
aria-expanded="false"
1818
aria-label="{l s='View my account (%s)' d='Shop.Theme.Customeraccount' sprintf=[$customerName]}">
19-
<i class="material-icons header-block__icon" aria-hidden="true">account_circle</i>
19+
<i class="material-icons header-block__icon" aria-hidden="true">&#xE853;</i>
2020
<span class="header-block__title d-none d-md-block d-lg-none">{$customer.firstname|capitalize|truncate:2:".":true}{$customer.lastname|capitalize|truncate:2:".":true}</span>
2121
<span class="header-block__title d-lg-inline d-none">{$customerName|capitalize|truncate:22:"...":true}</span>
2222
</a>
@@ -81,7 +81,7 @@
8181
class="header-block__action-btn"
8282
rel="nofollow"
8383
role="button">
84-
<i class="material-icons header-block__icon" aria-hidden="true">account_circle</i>
84+
<i class="material-icons header-block__icon" aria-hidden="true">&#xE853;</i>
8585
<span class="d-none d-md-inline header-block__title">{l s='Sign in' d='Shop.Theme.Actions'}</span>
8686
</a>
8787
</div>

modules/ps_emailalerts/views/templates/front/mailalerts-account-line.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@
1919
class="js-remove-email-alert btn btn-link {$componentName}__remove"
2020
rel="js-id-emailalerts-{$mailAlert.id_product|intval}-{$mailAlert.id_product_attribute|intval}"
2121
data-url="{url entity='module' name='ps_emailalerts' controller='actions' params=['process' => 'remove']}">
22-
<i class="material-icons" aria-label="{l s='Delete' d='Modules.Emailalerts.Shop'}">delete</i>
22+
<i class="material-icons" aria-label="{l s='Delete' d='Modules.Emailalerts.Shop'}">&#xE872;</i>
2323
</a>
2424
</div>

modules/ps_legalcompliance/views/templates/hook/hookDisplayFooter.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<div role="button" class="footer__block__toggle d-md-none collapsed" data-target="#footer_eu_about_us_list" data-bs-toggle="collapse">
1111
<span class="footer__block__title">{l s='Information' d='Modules.Legalcompliance.Shop'}</span>
12-
<i class="material-icons" aria-hidden="true">keyboard_arrow_down</i>
12+
<i class="material-icons" aria-hidden="true">&#xE313;</i>
1313
</div>
1414
<ul class="footer__block__content footer__block__content-list collapse" id="footer_eu_about_us_list">
1515
{foreach from=$cms_links item=cms_link}

0 commit comments

Comments
 (0)