Fix SymPy overflow error in solow lecture - #27
Merged
Conversation
The sympy code was using float values (A=2.0, alpha=0.3, delta=0.5) which caused 'OverflowError: mpz too large to convert to float' during symbolic computation. This fix: - Imports Rational from sympy - Defines A_sym, alpha_sym, delta_sym as Rational values for exact computation - Uses float() when printing s_star for display This matches the fix in the production lecture-python-intro repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The solow lecture was failing with:
This occurred because the sympy symbolic computation used Python float values (
A=2.0,alpha=0.3,delta=0.5) which caused overflow when SymPy tried to convert the result.Solution
Use
sympy.Rationalfor exact symbolic computation:This matches the fix in the production lecture-python-intro repository.
Changes
Rationalfrom sympyRationalfor exact computationfloat(s_star)when printing for display