Skip to content

Commit 399c2ab

Browse files
author
wuls
committed
fix conflict
2 parents b491a0d + f66c5e1 commit 399c2ab

File tree

110 files changed

+810
-619
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

110 files changed

+810
-619
lines changed

.changeset/changelog-github-custom.cjs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -351,12 +351,9 @@ var changelogFunctions = {
351351
.concat(links.pull || links.commit, ')');
352352
}
353353
emojiFirstline = firstLine
354-
.replace('FEAT:', '✨ ')
355-
.replace('feat:', '✨ ')
356-
.replace('fix:', '🐞🩹')
357-
.replace('FIX:', '🐞🩹')
358-
.replace('DOCS:', '📃')
359-
.replace('docs:', '📃');
354+
.replace(/feat:/i, '✨ ')
355+
.replace(/fix:/i, '🐞🩹')
356+
.replace(/docs:/i, '📃');
360357
return [
361358
2 /*return*/,
362359
'\n\n- '

.changeset/changelog-github-custom.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,9 @@ const changelogFunctions: ChangelogFunctions = {
116116
}
117117

118118
const emojiFirstline = firstLine
119-
.replace('FEAT:', '✨ ')
120-
.replace('feat:', '✨ ')
121-
.replace('fix:', '🐞🩹')
122-
.replace('FIX:', '🐞🩹')
123-
.replace('DOCS:', '📃')
124-
.replace('docs:', '📃');
119+
.replace(/feat:/i, '✨ ')
120+
.replace(/fix:/i, '🐞🩹')
121+
.replace(/docs:/i, '📃');
125122

126123
return `\n\n- ${emojiFirstline} ${suffix}\n${futureLines.map((l) => ` ${l}`).join('\n')}`;
127124
},

.changeset/eleven-rabbits-cross.md

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
---
2+
'@builder.io/qwik': minor
3+
---
4+
5+
Async functions in `useComputed` are deprecated.
6+
7+
**Why?**
8+
9+
- Qwik can't track used signals after the first await, which leads to subtle bugs.
10+
- When calculating the first time, it will see it's a promise and it will restart the render function.
11+
- Both `useTask` and `useResource` are available, without these problems.
12+
13+
In v2, async functions won't work.
14+
15+
Again, to get the same functionality use `useTask` or `useResource` instead, or this function:
16+
17+
```tsx
18+
export const useAsyncComputed$ = (qrlFn: QRL<() => Promise<any>>) => {
19+
const sig = useSignal();
20+
useTask(({ track }) => {
21+
const result = track(qrlFn);
22+
if (result && 'then' in result) {
23+
result.then(
24+
(val) => (sig.value = val),
25+
(err) => {
26+
console.error('async computed function threw!', err);
27+
throw error;
28+
}
29+
);
30+
} else {
31+
sig.value = result;
32+
}
33+
});
34+
return sig;
35+
};
36+
```

.changeset/funny-wasps-do.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@builder.io/qwik': patch
3+
---
4+
5+
FIX: QRL segment filenames are no longer lowercased. This was giving trouble with parent lookups in dev mode and there was no good reason for it.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@builder.io/qwik': patch
3+
---
4+
5+
FIX: the type for `<textarea>` now accepts text children, as per spec.

.changeset/lazy-worms-attack.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
'@builder.io/qwik-city': patch
33
---
44

5-
MDX content no longer ignores Layout components. See [the MDX docs](https://mdxjs.com/docs/using-mdx/#layout) for more information.
5+
FIX: MDX content no longer ignores Layout components. See [the MDX docs](https://mdxjs.com/docs/using-mdx/#layout) for more information.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@builder.io/qwik-city': patch
3+
---
4+
5+
FIX: SSG errors now show the path that failed

.changeset/many-turtles-cough.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
'@builder.io/qwik-city': patch
33
---
44

5-
Fix action redirect regression where searchParams were appended
5+
FIX: Fixed action redirect regression where searchParams were appended

.changeset/ninety-planets-search.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
'@builder.io/qwik': patch
44
---
55

6-
FIX: `vite` is now a peer dependency of `qwik` and `qwik-city`, so that there can be no duplicate imports. This should not have consequences, since all apps also directly depend on `vite`.
6+
FIX: `vite` is now a peer dependency of `qwik`, `qwik-city`, `qwik-react` and `qwik-labs`, so that there can be no duplicate imports. This should not have consequences, since all apps also directly depend on `vite`.

.changeset/real-garlics-argue.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
'@builder.io/qwik-city': patch
33
---
44

5-
Fixed MDX layout default export being ignored by transformer.
5+
FIX: Fixed MDX layout default export being ignored by transformer.

0 commit comments

Comments
 (0)