Open
Conversation
PritishWadhwa
approved these changes
May 10, 2022
aucampia
reviewed
May 10, 2022
SPARQLWrapper/Wrapper.py
Outdated
| _validate_format("JSON", [JSON], ct, self.requestedFormat) | ||
| return self._convertJSON() | ||
| elif _content_type_in_list(ct, _RDF_XML): | ||
| #Ananya: This has to be altered |
Author
There was a problem hiding this comment.
Removing these would cause an error some asserts in the test file.
Altering those too.
Member
aucampia
reviewed
May 10, 2022
Comment on lines
+777
to
+778
| elif self.returnFormat == RDF: | ||
| raise ValueError("A SPARQL SELECT query doesn't return RDF, so RDF here is not a valid selection for a return type. Return types of JSON & XML are valid.") |
Windows CR+LF line endings is causing the problem. @ananya2711 see https://fedingo.com/how-to-configure-line-endings-in-git-commit/ |
b38f20e to
8ffef6e
Compare
|
Please remove the spurious file |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added ValueError for invalid select query with RDF return format.
Issue 190