From a88671d747ddcda4534b6b41e541f974b2bc1099 Mon Sep 17 00:00:00 2001 From: Eugene Volen Date: Thu, 18 Jun 2026 13:41:15 +0000 Subject: [PATCH 1/2] Build only shipped binaries in nightly/release (speed up) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The nightly/release build steps ran `cargo build --release --workspace`, compiling the full workspace in release mode inside manylinux — including the standalone rocm-engine-* binaries and rocm-dash-daemon that are no longer shipped (the bundle is rocm + rocmd), plus all test/example targets. Narrow the build to the binaries that are actually packaged plus the signing tool: `cargo build --release -p rocm -p rocmd -p xtask`. The engine library crates still compile (they are linked into rocm for the in-process engines), so behavior is unchanged; we just skip the redundant binary link/codegen steps. Full-workspace compilation remains covered by ci.yml's build-and-test. --- .github/workflows/nightly.yml | 4 ++-- .github/workflows/release.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 55fed936..62c6f168 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -92,7 +92,7 @@ jobs: curl -fsSL https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain none --no-modify-path fi export PATH="/host-cargo/bin:$PATH" - cargo build --release --workspace + cargo build --release -p rocm -p rocmd -p xtask ' - name: Set nightly metadata @@ -184,7 +184,7 @@ jobs: - name: Build release binaries shell: pwsh - run: cargo build --release --workspace + run: cargo build --release -p rocm -p rocmd -p xtask - name: Package Windows bundle shell: pwsh diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index df020a51..4194c4bf 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -97,7 +97,7 @@ jobs: curl -fsSL https://sh.rustup.rs | sh -s -- -y --profile minimal --default-toolchain none --no-modify-path fi export PATH="/host-cargo/bin:$PATH" - cargo build --release --workspace + cargo build --release -p rocm -p rocmd -p xtask ' - name: Package release bundle @@ -168,7 +168,7 @@ jobs: - name: Build release binaries shell: pwsh - run: cargo build --release --workspace + run: cargo build --release -p rocm -p rocmd -p xtask - name: Package Windows bundle shell: pwsh From b4523d7c7a3c019fe3525f4be65b6f36ef587fcf Mon Sep 17 00:00:00 2001 From: Eugene Volen Date: Thu, 18 Jun 2026 13:46:01 +0000 Subject: [PATCH 2/2] Fix nightly publish: don't --cleanup-tag the draft staging release publish-nightly ended with `gh release delete "$STAGING_TAG" --yes --cleanup-tag`, which failed the job with HTTP 422 "Reference does not exist": the staging release is created as a --draft, and draft releases never create a git tag, so there is nothing for --cleanup-tag to delete. The rolling `nightly` release and all assets had already been published successfully; only this final cleanup line failed. Drop --cleanup-tag (delete just the draft) and tolerate errors, matching the other two staging-delete sites. --- .github/workflows/nightly.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 62c6f168..fee9758a 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -292,7 +292,9 @@ jobs: "${EXTRA}/rocm" "${EXTRA}/rocm.exe" \ "${EXTRA}/linux-binaries.tar.gz" "${EXTRA}/windows-binaries.zip" --clobber - gh release delete "${STAGING_TAG}" --yes --cleanup-tag + # The staging release is a draft, which never creates a git tag, so + # --cleanup-tag would 422 on a nonexistent ref. Just delete the draft. + gh release delete "${STAGING_TAG}" --yes 2>/dev/null || true cleanup-staging-nightly: name: Clean failed nightly staging release