From e28963f166a0f3df8543a0cc7592603367479ddc Mon Sep 17 00:00:00 2001 From: DingDing Date: Mon, 7 Aug 2023 10:20:15 +0800 Subject: [PATCH 1/4] Update wlan_dev.c fix warning: warning: unused variable 'len' warning: 'buff.data' may be used uninitialized in this function --- components/drivers/wlan/wlan_dev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/components/drivers/wlan/wlan_dev.c b/components/drivers/wlan/wlan_dev.c index 167c4ccb8d7..3ce3ce318be 100644 --- a/components/drivers/wlan/wlan_dev.c +++ b/components/drivers/wlan/wlan_dev.c @@ -123,9 +123,7 @@ rt_err_t rt_wlan_dev_connect(struct rt_wlan_device *device, struct rt_wlan_info rt_err_t rt_wlan_dev_fast_connect(struct rt_wlan_device *device, struct rt_wlan_info *info, const char *password, int password_len) { rt_err_t result = RT_EOK; - struct rt_wlan_buff buff; - - int len = 0; + struct rt_wlan_buff buff = {0}; if (device == RT_NULL) { From 6dbaaf4763e99496c464a54ed76214de1b53fccc Mon Sep 17 00:00:00 2001 From: DingDing Date: Mon, 7 Aug 2023 10:30:43 +0800 Subject: [PATCH 2/4] Update wlan_mgnt.c fix warning: variables not used. --- components/drivers/wlan/wlan_mgnt.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/components/drivers/wlan/wlan_mgnt.c b/components/drivers/wlan/wlan_mgnt.c index 85064cc2718..f6c0f26d958 100644 --- a/components/drivers/wlan/wlan_mgnt.c +++ b/components/drivers/wlan/wlan_mgnt.c @@ -842,7 +842,6 @@ static void rt_wlan_join_scan_callback(int event, struct rt_wlan_buff *buff, voi { struct rt_wlan_info *info = RT_NULL; struct rt_wlan_info *tgt_info = RT_NULL; - int ret = RT_EOK; RT_ASSERT(event == RT_WLAN_EVT_SCAN_REPORT); RT_ASSERT(buff != RT_NULL); @@ -880,7 +879,6 @@ rt_err_t rt_wlan_connect(const char *ssid, const char *password) struct rt_wlan_info info; struct rt_wlan_complete_des *complete; rt_uint32_t set = 0, recved = 0; - rt_uint32_t scan_retry = RT_WLAN_SCAN_RETRY_CNT; /* sta dev Can't be NULL */ if (_sta_is_null()) @@ -1584,7 +1582,6 @@ rt_err_t rt_wlan_scan_with_info(struct rt_wlan_info *info) rt_err_t err = RT_EOK; struct rt_wlan_complete_des *complete; rt_uint32_t set = 0, recved = 0; - static struct rt_wlan_info scan_filter_info; if (_sta_is_null()) { From f550dbd2f02ab5d33b943d4d3d89315f4e062e63 Mon Sep 17 00:00:00 2001 From: DingDing Date: Mon, 7 Aug 2023 10:46:53 +0800 Subject: [PATCH 3/4] Update wlan_dev.c init the struct objects. --- components/drivers/wlan/wlan_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/drivers/wlan/wlan_dev.c b/components/drivers/wlan/wlan_dev.c index 3ce3ce318be..4fc5839aea8 100644 --- a/components/drivers/wlan/wlan_dev.c +++ b/components/drivers/wlan/wlan_dev.c @@ -371,7 +371,7 @@ rt_err_t rt_wlan_dev_unregister_event_handler(struct rt_wlan_device *device, rt_ void rt_wlan_dev_indicate_event_handle(struct rt_wlan_device *device, rt_wlan_dev_event_t event, struct rt_wlan_buff *buff) { void *parameter[RT_WLAN_DEV_EVENT_NUM]; - rt_wlan_dev_event_handler handler[RT_WLAN_DEV_EVENT_NUM]; + rt_wlan_dev_event_handler handler[RT_WLAN_DEV_EVENT_NUM] = {0}; int i; rt_base_t level; From a3e057f83cd097489f3f64690cafc37658e8b341 Mon Sep 17 00:00:00 2001 From: DingDing Date: Mon, 7 Aug 2023 10:53:32 +0800 Subject: [PATCH 4/4] Update wlan_dev.c init the parameters array. --- components/drivers/wlan/wlan_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/drivers/wlan/wlan_dev.c b/components/drivers/wlan/wlan_dev.c index 4fc5839aea8..da4aa57497e 100644 --- a/components/drivers/wlan/wlan_dev.c +++ b/components/drivers/wlan/wlan_dev.c @@ -370,7 +370,7 @@ rt_err_t rt_wlan_dev_unregister_event_handler(struct rt_wlan_device *device, rt_ void rt_wlan_dev_indicate_event_handle(struct rt_wlan_device *device, rt_wlan_dev_event_t event, struct rt_wlan_buff *buff) { - void *parameter[RT_WLAN_DEV_EVENT_NUM]; + void *parameter[RT_WLAN_DEV_EVENT_NUM] = {0}; rt_wlan_dev_event_handler handler[RT_WLAN_DEV_EVENT_NUM] = {0}; int i; rt_base_t level;